fix: preserve MCP toolsets when saving platform tools#1390
Open
fix: preserve MCP toolsets when saving platform tools#1390
Conversation
When using `hermes tools` to configure toolsets, MCP server names were being removed from platform_toolsets because _save_platform_tools only saved CONFIGURABLE_TOOLSETS entries. This fix preserves any non-configurable entries (like MCP server names) that were already in the config, merging them with the user's new selection. Closes #1247
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainmcp-<server>) whenhermes toolssavesplatform_toolsetshermes-*platform presets, which would otherwise re-expand the full preset after a user narrows their selectionWhy
The original PR was addressing a real bug:
hermes toolscould strip dynamic MCP toolsets fromplatform_toolsetson save. On currentmain, the stale branch needed conflict resolution, and the preservation rule needed tightening so we only keep real MCP dynamic toolsets instead of every non-configurable entry.Contributor credit:
mainTest plan
python -m pytest tests/hermes_cli/test_tools_config.py tests/tools/test_mcp_tool.py -n0 -qpython -m pytest tests/ -n0 -q