Improve error logging in MCP tool#1353
Open
aydnOktay wants to merge 1 commit intoNousResearch:mainfrom
Open
Conversation
- Add exc_info=True to all error/warning logs in mcp_tool.py - Upgrade exception handlers from logger.debug to logger.error with exc_info=True - Ensures full stack traces are included in logs for better debugging - Covers reconnection failures, connection lost warnings, tool call errors, and shutdown errors - Consistent with error logging patterns in other tools (browser_tool, web_tools, tts_tool)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enhances error observability in
mcp_tool.pyby addingexc_info=Trueto all error and warning logs, ensuring full stack traces are included for better debugging. The changes upgrade exception handlers fromlogger.debugtologger.errorwithexc_info=Truefor config loading failures and shutdown errors, and addexc_info=Trueto reconnection failure warnings, connection lost warnings, and all MCP tool call errors (tool calls, list_resources, read_resource, list_prompts, and get_prompt). These improvements provide consistent error logging patterns across the codebase, align with CONTRIBUTING.md guidance, and make it significantly easier to diagnose MCP server connection issues, tool call failures, and other errors during development and production debugging.