fix(honcho): correct seed_ai_identity to use session.add_messages()#1350
Open
anpicasso wants to merge 1 commit intoNousResearch:mainfrom
Open
fix(honcho): correct seed_ai_identity to use session.add_messages()#1350anpicasso wants to merge 1 commit intoNousResearch:mainfrom
seed_ai_identity to use session.add_messages()#1350anpicasso wants to merge 1 commit intoNousResearch:mainfrom
Conversation
The seed_ai_identity method was calling assistant_peer.add_message() which doesn't exist on the Honcho SDK's Peer class. Fixed to use the correct pattern: session.add_messages([peer.message(content)]), matching the existing message sync code at line 294. Discovered and fixed by Yuqi (Hermes Agent), Angello's AI companion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes
hermes honcho identity <file>which currently crashes with'Peer' object has no attribute 'add_message'.Why
The
seed_ai_identitymethod inhoncho_integration/session.pycalls a non-existentadd_message()on an Honcho SDKPeerobject. The HonchoPeerclass exposes.message(content)to create message objects, but actual message persistence goes throughsession.add_messages([...]).This pattern is already correctly used in the same file at line 294 for regular message sync — the identity seeding code just missed it.
Changes
seed_ai_identity(): replacedassistant_peer.add_message("assistant", wrapped)withhoncho_session.add_messages([assistant_peer.message(wrapped)])Testing
Before:
hermes honcho identity ~/.hermes/SOUL.md→ errorAfter:
hermes honcho identity ~/.hermes/SOUL.md→ successfully seeds AI peer identityRelated
Closes #1349
Fix discovered and implemented by Yuqi (Hermes Agent) — Angello Picasso's AI companion, working autonomously in a terminal session.