fix(update): reinstall editable package with extras #1342
fix(update): reinstall editable package with extras #1342baketnk wants to merge 1 commit intoNousResearch:mainfrom
Conversation
54b86c1 to
279b291
Compare
|
Reading through the docs again, looks like [all] might not be intended here - might close and think this over. The problem being, if [all] is pulled by the big dumdum install script, users won't realize there are [extras] for hermes-agent itself. I might close this and rework it to instead print a warning if the voice commands are used without the imports being available. |
|
Thanks for digging into this. I think the direction is right: using A couple changes would make this ready:
If you want to revise along those lines, I think this becomes mergeable. |
What does this PR do?
Modifies
hermes updateto use.[all]to include extras when updating dependencies, to fix cases where extras are added later in development. Currently.[all]is used by install, but not by theupdatecommand.Related Issue
Fixes #1336
Type of Change
Changes Made
As above, use
.[all]for complete dependency updates. The LLM made a few formatting changes that you can nit at, I glomarize them.How to Test
Before the discord voice update: install version, then update after voice. voice channel connect fails because of missing deps in venv. (PyNaCl, davey)
Checklist
idk
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/A