Skip to content

Conversation

@glebbg
Copy link

@glebbg glebbg commented Nov 25, 2025

PR Type

  • RL Environment PR - Complete Environment Snapshot & Zero-Training sections
  • Non-Environment PR - Complete Description, Related Issues & Type of Change sections

📝 General Information

Description

This PR eliminates code duplication by extracting the resolve_openai_configs function that was identically implemented in three server modules (vllm_server.py, sglang_server.py, openai_server.py) into a dedicated utility module config_utils.py.

Related Issues

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code refactor (no functional changes)
  • Build/CI/CD related changes
  • Other (please describe):

🔖 Environment Snapshot

Field Your Entry
Environment Name
Short Description
Category
Dataset Needed?
External Deps
Environmental Variables
Compute Footprint Estimate

🧪 Zero-Training Test Results

Details

W&B Link:

Examples of the Environment scoring a good example and a bad example:


✅ Developer & Reviewer Checklist

  • Code follows project style (black, isort, flake8 pass with pre-commit)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Docstrings added for all new public classes / functions
  • If .env vars required, did you add it to the .env.example in repo root?

@glebbg
Copy link
Author

glebbg commented Dec 22, 2025

Hello @dmahan93, can you check please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant