Skip to content

Fix delete method #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nottezz merged 3 commits into from
Feb 10, 2026
Merged

Fix delete method #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
baed65c
fix delete method
Nottezz Feb 9, 2026
6ab303f
fix lint
Nottezz Feb 10, 2026
e1cb664
fix isort
Nottezz Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions backend/backlog_app/api/crud.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ async def create_movie(
await db.commit()
await db.refresh(movie)

logger.info("Movie has been created.")
logger.info("Movie <%s> has been created.", movie.id)

return MovieRead(
id=movie.id,
Expand Down Expand Up @@ -153,7 +153,7 @@ async def delete_movie(
db: AsyncSession,
movie_id: int,
user: User,
) -> Movie | None:
) -> None:
result = await db.execute(select(Movie).where(Movie.id == movie_id))
movie = result.scalars().first()
if not movie:
Expand All @@ -164,9 +164,7 @@ async def delete_movie(
await db.delete(movie)
await db.commit()

logger.info("Movie has been deleted.")

return movie
logger.info("Movie <%s> has been deleted.", movie_id)


def check_movie_ownership(movie: Movie, user: User) -> None:
Expand Down
9 changes: 6 additions & 3 deletions backend/backlog_app/api/view/movie_view.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from typing import Annotated, List

from fastapi import APIRouter, Depends
from fastapi import APIRouter, Depends, status
from sqlalchemy.ext.asyncio import AsyncSession

from backlog_app.api import crud
Expand All @@ -14,7 +14,7 @@
router = APIRouter(prefix="/movies", tags=["Movies"])


@router.post("/", response_model=MovieRead)
@router.post("/", response_model=MovieRead, status_code=status.HTTP_201_CREATED)
async def add_movie(
movie_create: MovieCreate,
db: Annotated[AsyncSession, Depends(get_async_session)],
Expand Down Expand Up @@ -66,7 +66,10 @@ async def partial_update_movie(
return await crud.partial_update_movie(db, movie_id, movie_update)


@router.delete("/{movie_id}", response_model=MovieRead)
@router.delete(
"/{movie_id}",
status_code=status.HTTP_204_NO_CONTENT,
)
async def delete_movie(
movie_id: int,
db: Annotated[AsyncSession, Depends(get_async_session)],
Expand Down
6 changes: 4 additions & 2 deletions backend/backlog_app/schemas/movie.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
from annotated_types import Len
from pydantic import BaseModel, Field

from .user import UserRead


class MovieBase(BaseModel):
title: Annotated[str, Len(min_length=3, max_length=255)]
Expand All @@ -14,6 +16,8 @@ class MovieBase(BaseModel):
kp_id: int | None = None
imdb_id: int | None = None

model_config = {"from_attributes": True}


class MovieCreate(MovieBase):
description: Annotated[str, Len(min_length=20, max_length=1000)] | None = None
Expand All @@ -37,5 +41,3 @@ class MovieRead(MovieBase):
watched: bool
rating: float | None
created_at: datetime

model_config = {"from_attributes": True}
Loading