Material path resolver rewrite to be more robust #117
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue where non-vanilla material names would cause this function to a) fault because the material string was too short and would cause one of the functions to break, or b) return garbage since they dont conform to vanilla naming conventions (most of the time). This rewrite uses regex to check for the syntax safely in one regex match. I confirmed the function works using Penumbra and passing various material names and monitoring behavior.