feat: add transparency supporting base16-pro-max theme#1244
Open
ced4rtree wants to merge 7 commits intoNotAShelf:v0.8from
Open
feat: add transparency supporting base16-pro-max theme#1244ced4rtree wants to merge 7 commits intoNotAShelf:v0.8from
ced4rtree wants to merge 7 commits intoNotAShelf:v0.8from
Conversation
The standard base16 theme does not have support for transparency. The base16-pro-max theme by @y3owk1n does, though.
Update changelog to reflect new theme
ced4rtree
requested review from
NotAShelf,
Soliprem and
horriblename
as code owners
ced4rtree
changed the title
Soliprem
reviewed
Nov 26, 2025
Soliprem
approved these changes
Nov 28, 2025
Collaborator
Soliprem
left a comment
Soliprem
left a comment
There was a problem hiding this comment.
LGTM now. Thanks for the work!
Collaborator
|
CI shows a formatting issue. Did you run the formatter after making the adjustments? |
Contributor
Author
This seems to be caused by the release notes added in #1246, and is present on the v0.8 branch at the moment |
Collaborator
|
oh mb, thanks. Weird because I don't remember the CI complaining then... LGTM then. it's clearly unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Neither the standard nor mini base16 themes have support for transparency. The base16-pro-max theme by @y3owk1n does, though.
Fixes #1091
Sanity Checking
nix fmt).#nix(default package).#maximal.#docs-html(manual, must build).#docs-linkcheck(optional, please build if adding links)x86_64-linuxaarch64-linuxx86_64-darwinaarch64-darwinAdd a 👍 reaction to pull requests you find important.