Skip to content

feat: Completed emmet-ls integrations#1235

Open
valyntyler wants to merge 5 commits intoNotAShelf:v0.8from
valyntyler:emmet-ls
Open

feat: Completed emmet-ls integrations#1235
valyntyler wants to merge 5 commits intoNotAShelf:v0.8from
valyntyler:emmet-ls

Conversation

@valyntyler
Copy link
Contributor

Sanity Checking

  • I have updated the changelog as per my changes
  • I have tested, and self-reviewed my code
  • My changes fit guidelines found in hacking nvf
  • Style and consistency
    • I ran Alejandra to format my code (nix fmt)
    • My code conforms to the editorconfig configuration of the project
    • My changes are consistent with the rest of the codebase
  • If new changes are particularly complex:
    • My code includes comments in particularly complex areas
    • I have added a section in the manual
    • (For breaking changes) I have included a migration guide
  • Package(s) built:
    • .#nix (default package)
    • .#maximal
    • .#docs-html (manual, must build)
    • .#docs-linkcheck (optional, please build if adding links)
  • Tested on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

Add a 👍 reaction to pull requests you find important.

@github-actions
Copy link

github-actions bot commented Nov 19, 2025

🚀 Live preview deployed from 913dd0d

View it here:

Debug Information

Triggered by: valyntyler

HEAD at: emmet-ls

Reruns: 1595

github-actions bot pushed a commit that referenced this pull request Nov 19, 2025
@valyntyler valyntyler mentioned this pull request Nov 20, 2025
17 tasks
Copy link
Owner

@NotAShelf NotAShelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Emmet-ls is currently present in the master branch. Two things I want to note:

  1. Should this be a default server? I don't think emmet is that common of a language, so it should be opt-in UNLESS it enhances the basic HTML experience. Duplicating LSPs is also not too desirable. If emmet is this divergent, it might be preferrable that we make it its own language module.

  2. Are those root markers accurate?

Lastly, the changelog entries will have to go into 0.9 instead.

Sorry for the very delayed review; I've managed to miss this PR somehow. With minor tweaks I should be able to merge this.

@valyntyler
Copy link
Contributor Author

Hey! Thanks for the update!
I can definitely see this being it's own module, and I think that is a quite elegant solution. On the other hand, emmet-ls doesn't to my knowledge interfere with any of the default servers, which is why I suggested it as a default (for people who are used to doing web dev in vscode). Let me know which one you prefer and I'll update the PR accordingly.

@github-actions github-actions bot deleted the branch NotAShelf:v0.8 March 1, 2026 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants