feat: Completed emmet-ls integrations#1235
feat: Completed emmet-ls integrations#1235valyntyler wants to merge 5 commits intoNotAShelf:v0.8from
emmet-ls integrations#1235Conversation
NotAShelf
left a comment
There was a problem hiding this comment.
Emmet-ls is currently present in the master branch. Two things I want to note:
-
Should this be a default server? I don't think emmet is that common of a language, so it should be opt-in UNLESS it enhances the basic HTML experience. Duplicating LSPs is also not too desirable. If emmet is this divergent, it might be preferrable that we make it its own language module.
-
Are those root markers accurate?
Lastly, the changelog entries will have to go into 0.9 instead.
Sorry for the very delayed review; I've managed to miss this PR somehow. With minor tweaks I should be able to merge this.
|
Hey! Thanks for the update! |
Sanity Checking
nix fmt).#nix(default package).#maximal.#docs-html(manual, must build).#docs-linkcheck(optional, please build if adding links)x86_64-linuxaarch64-linuxx86_64-darwinaarch64-darwinAdd a 👍 reaction to pull requests you find important.