Skip to content

Comments

Address review feedback: improve clarity and add examples#339

Merged
timowestnosto merged 2 commits intopsn-guidefrom
copilot/sub-pr-338
Dec 1, 2025
Merged

Address review feedback: improve clarity and add examples#339
timowestnosto merged 2 commits intopsn-guidefrom
copilot/sub-pr-338

Conversation

Copy link

Copilot AI commented Dec 1, 2025

Addressed 11 review comments from code review on documentation clarity, grammar, and examples.

Grammar and terminology fixes

  • Fixed "varies on" → "varies based on" for grammatical correctness
  • Corrected article usage: "an frontend API" → "a frontend API"
  • Updated terminology: "Nosto backend" → "Nosto Admin UI", "Nosto-hosted templates" → "templates hosted at Nosto"
  • Removed temporal qualifier from SKU limitation statement for clarity

Improved clarity

  • Changed "One or multiple modules" → "One or both of the following Nosto modules"
  • Refined client guidance from "will tell you" → "will guide you on setting up"
  • Clarified customer data context: "if the customer is logged in" → "customer details if the customer is logged in"
  • Added context qualifier "when using a custom code setup" for API approach recommendation

Added examples and references

  • Added Session API page tracking code example:
nostojs(api => {
  api.defaultSession()
    .viewProduct("product-123")
    .setPlacements(api.placements.getPlacements())
    .load()
});
  • Added reference link to parameterless attribution documentation for DOM injection section

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: timowestnosto <13622115+timowestnosto@users.noreply.github.com>
Copilot AI changed the title [WIP] Update personalization guide with code changes Address review feedback: improve clarity and add examples Dec 1, 2025
Copilot AI requested a review from timowestnosto December 1, 2025 08:14
@timowestnosto timowestnosto marked this pull request as ready for review December 1, 2025 08:39
@timowestnosto timowestnosto merged commit c097f58 into psn-guide Dec 1, 2025
@timowestnosto timowestnosto deleted the copilot/sub-pr-338 branch December 1, 2025 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants