build: migrate repository to use CodeArtifact in build and publish#90
Merged
welociraptor merged 5 commits intomasterfrom Feb 19, 2026
Merged
build: migrate repository to use CodeArtifact in build and publish#90welociraptor merged 5 commits intomasterfrom
welociraptor merged 5 commits intomasterfrom
Conversation
|
@codex review |
leanish
reviewed
Feb 19, 2026
framework/build.gradle
Outdated
| username = "$mavenUser" | ||
| password = "$mavenPassword" | ||
| username = "aws" | ||
| password = System.getenv("CODEARTIFACT_AUTH_TOKEN") |
There was a problem hiding this comment.
shouldn't it be providers.environmentVariable("CODEARTIFACT_AUTH_TOKEN")?
There was a problem hiding this comment.
once here, you could also add .orElse(providers.gradleProperty("<the_key>"))
leanish
reviewed
Feb 19, 2026
framework/build.gradle
Outdated
| username "$mavenUser" | ||
| password "$mavenPassword" | ||
| username = "aws" | ||
| password = System.getenv("CODEARTIFACT_AUTH_TOKEN") |
leanish
reviewed
Feb 19, 2026
framework/build.gradle
Outdated
| username "$mavenUser" | ||
| password "$mavenPassword" | ||
| username = "aws" | ||
| password = System.getenv("CODEARTIFACT_AUTH_TOKEN") |
welociraptor
force-pushed
the
codeartifact
branch
from
0777354 to
1f50fcb
Compare
leanish
reviewed
Feb 19, 2026
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up JDK | ||
| uses: actions/setup-java@v4 |
leanish
reviewed
Feb 19, 2026
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 |
leanish
reviewed
Feb 19, 2026
Comment on lines
28
to
34
| export CODEARTIFACT_AUTH_TOKEN=$(aws codeartifact get-authorization-token \ | ||
| --domain ${{ vars.CODEARTIFACT_DOMAIN }} \ | ||
| --domain-owner ${{ vars.CODEARTIFACT_DOMAIN_OWNER }} \ | ||
| --region ${{ env.AWS_REGION }} \ | ||
| --query authorizationToken \ | ||
| --output text) | ||
| echo "CODEARTIFACT_AUTH_TOKEN=$CODEARTIFACT_AUTH_TOKEN" >> $GITHUB_ENV |
There was a problem hiding this comment.
I guess this will also need to be updated to the latest approach?
leanish
reviewed
Feb 19, 2026
Comment on lines
+214
to
+217
| url = "$mavenUrl" | ||
| credentials { | ||
| username "$mavenUser" | ||
| password "$mavenPassword" | ||
| username = "$mavenUser" | ||
| password = "$mavenPassword" |
There was a problem hiding this comment.
I assume these 3 come from Gradle itself?
Author
There was a problem hiding this comment.
I guess so. I assume there's no difference whether there is the equals sign or if it's omitted.
leanish
approved these changes
Feb 19, 2026
leanish
left a comment
leanish
left a comment
There was a problem hiding this comment.
I added a question, but LGTM if "yes" (or no with another reliable variable-value source)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.