Closed
Conversation
* using diamonds instead of explicit types; * using already casted variable; * using StringBuilder instead of String concatenation in loop; * remove unnecessary method argument; * remove redundant if-statement; * using unwrap() instead of getDelegate() and type cast.
…ed via an `@Audited` annotation, it attempts to insert a record in a related `AUD` table. However, Play! assumes all related entities extend `JPABase`, which the `AUD` tables don't. This leads to a `ClassCastException` because `HashMap` is cast to `JPABase`. By adding a check for `JPABase` here, we can avoid this problem. This effectively also checks for 'not null' which the previous implementation did.
…e_20221009 Updated 3rd party library dependencies
…e-20230106 Dependency update 20230106
…Lang Upgrade Commons Lang
…t_return_0_on_failure issue #59: play auto-test can return an exit code of zero when the te…
…ot-get-unused-value Bugfix/1430 do not get unused value
This supports Java 20
…for JDK 11" This reverts commit 663a132.
…ate_20230714 Updated 3rd party dependencies
Better compatibility with Hibernate Envers
playframework#1444 Fix missing HTTPMessage.getHeader()
- checkout from v2 to v4 - setup-python from v3 to v4 - setup-java from v2 to v3
# Conflicts: # framework/dependencies.yml # framework/lib/mysql-connector-j-8.1.0.jar # framework/src/play/classloading/ApplicationClassloader.java # framework/src/play/test/PlayJUnitRunner.java
…odule 1457 python imp module
# Conflicts: # samples-and-tests/i-am-a-developer/tests.py
d8320ca to
286271c
Compare
286271c to
7509a5a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Helpful things
Fixes
Fixes #xxxx
Purpose
What does this PR do?
Background Context
Why did you take this approach?
References
Are there any relevant issues / PRs / mailing lists discussions?