Skip to content

Comments

fix: resolve ESLint 10 compatibility issues#239

Merged
timowestnosto merged 2 commits intodependabot/npm_and_yarn/eslint/js-10.0.1from
copilot/sub-pr-229
Feb 23, 2026
Merged

fix: resolve ESLint 10 compatibility issues#239
timowestnosto merged 2 commits intodependabot/npm_and_yarn/eslint/js-10.0.1from
copilot/sub-pr-229

Conversation

Copy link
Contributor

Copilot AI commented Feb 23, 2026

Context

ESLint 10 introduced two new rules causing lint failures: preserve-caught-error requires error chaining when rethrowing, and no-useless-assignment flags unused initial assignments.

Changes:

  • Added { cause: error } to preserve error chain when rethrowing in:
    • src/api/retry.ts - retry operation failures
    • src/config/authConfig.ts - auth file parsing errors
    • src/config/fileConfig.ts - config file parsing errors
  • Removed useless initial null assignment in src/modules/deployments/redeploy.ts

Example:

// Before
throw new Error(`Invalid auth file: ${error.message}`)

// After
throw new Error(`Invalid auth file: ${error.message}`, { cause: error })

Related Jira ticket

N/A - Dependency update maintenance

Screenshots

N/A


🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

- Add error cause to preserve error chain in retry.ts, authConfig.ts, and fileConfig.ts
- Remove useless initial assignment in redeploy.ts

Co-authored-by: timowestnosto <13622115+timowestnosto@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 23, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • api.nosto.com
    • Triggering command: /opt/hostedtoolcache/node/24.13.0/x64/bin/node /opt/hostedtoolcache/node/24.13.0/x64/bin/node --conditions node --conditions development --experimental-import-meta-resolve --require /home/REDACTED/work/nosto-cli/nosto-cli/node_modules/vitest/suppress-warnings.cjs /home/REDACTED/work/nosto-cli/nosto-cli/node_modules/vitest/dist/workers/forks.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Update @eslint/js from 9.39.2 to 10.0.1 fix: resolve ESLint 10 compatibility issues Feb 23, 2026
Copilot AI requested a review from timowestnosto February 23, 2026 06:48
@timowestnosto timowestnosto marked this pull request as ready for review February 23, 2026 07:11
@timowestnosto timowestnosto merged commit 100c737 into dependabot/npm_and_yarn/eslint/js-10.0.1 Feb 23, 2026
3 checks passed
@timowestnosto timowestnosto deleted the copilot/sub-pr-229 branch February 23, 2026 07:12
@nosto-release-public
Copy link

🎉 This PR is included in version 1.2.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants