fix: wait for PgBouncer to be fully operational before running tests #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added wait_for_pgbouncer() function that: 1. Waits for container health status to be "healthy" 2. Waits for PgBouncer to accept connections and respond to SHOW VERSION This fixes race condition where tests would fail if PgBouncer was still initializing when the test suite started, even though the container was marked as healthy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes race condition in PgBouncer test suite where tests would fail if PgBouncer was still initializing.
Problem
When running the full test suite immediately after starting services, PgBouncer tests would fail (1/10 passed) because:
Solution
Added
wait_for_pgbouncer()function that:SHOW VERSIONcommandTest plan