Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This isn't complete, but i18n loaded NLS bundles do not seem to export an object in the same format in a webpack bundle that the i18n plugin returns. The generated module contains the available languages (and root) as properties, but the i18n plugin resolves the appropriate language and returns the appropriate language-flattened object. I am not sure if there is a way for the generated module to call something in dojo/i18n do this flattening based on the current locale.
In our app, we got an error loading dgrid/extensions/Pagination, because instead of a
statusobject, there is just an object with arootproperty (that contains an object with astatus). This PR is just a quick hack to resolve to therootvalue instead, because our app just runs in English/root.