Open
Conversation
This was
linked to
issues
Oct 14, 2023
taoliu12
commented
Oct 14, 2023
| const { classes } = useStyles(); | ||
| const { assets, headerContentRight, headerText } = props; | ||
| if (!assets) return <> </>; | ||
| if (!assets || !Array.isArray(assets)) return <> No Results</>; |
Contributor
Author
There was a problem hiding this comment.
assets was coming back as an error object when DB is unseeded, so I added a check for if it is an array.
esteban-gs
requested changes
Oct 15, 2023
Contributor
esteban-gs
left a comment
esteban-gs
left a comment
There was a problem hiding this comment.
This looks fine to me, maybe safer to do a nullish check like:
{assets && assets.map(...
Looking into this, it seems that the server returning a 500 error should be handled in the fetch call. Right now that fetch call isn't catching any errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the linked issues regarding the search error when database is not migrated.
Dev Summary
Mocks
Test Plan
repro steps:
expected:
Resources