Skip to content

around-each with non-interwoven ordering#34

Closed
edenworky wants to merge 3 commits intoNoahTheDuke:mainfrom
edenworky:main
Closed

around-each with non-interwoven ordering#34
edenworky wants to merge 3 commits intoNoahTheDuke:mainfrom
edenworky:main

Conversation

@edenworky
Copy link
Copy Markdown
Contributor

as per #31

@edenworky edenworky mentioned this pull request Mar 22, 2026
@seancorfield
Copy link
Copy Markdown
Contributor

This looks pretty good to me.

@NoahTheDuke
Copy link
Copy Markdown
Owner

i don't like the difference between before/around/after and around-each/before-each/after-each, but i think that's going to be largely immaterial, and if i'm going to make a change, it would be to move before and after inside around. i think this is good overall, and i'm glad that adding it was relatively easy for you. i have a fairly big pr in the works (#33) so i'll probably merge this manually to get it synced up with that one, and then cut a release. i'm not sure exactly when i'll do that this week, but it'll be soon.

thanks so much for the help!

@NoahTheDuke
Copy link
Copy Markdown
Owner

NoahTheDuke commented Mar 23, 2026

i manually merged/rebased with jj, which changed the commit hashes:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants