Reformat text to have at most one sentence per line #197
Conversation
|
An idea that just occurred to me is whether this information belongs more in |
cafkafk
left a comment
cafkafk
left a comment
There was a problem hiding this comment.
I normally prefer to use line wrapping, but specially for things such as the constitution, I can't argue against the value of semantic line breaks, makes it more reviewable.
I would want to just get eyeballs from the rest of the SC on this, within reason (e.g., next few days), to make sure we're aligned on this, and that this didn't accidentally introduce any changes to the meaning of this document.
But in my reading, it didn't[1].
[1]: Also, while it is true that rendered markdown might in theory not affect the meaning of the text, this is less so the case as changes are introduced across lists and other elements.
roberth
left a comment
roberth
left a comment
There was a problem hiding this comment.
I do not care for line breaks. Semantic line breaks should be called increased-entropy line breaks. Bike shed line breaks?
Clearly some people do care, so I won't block whatever this is.
| The SC has the authority to make decisions within the scope of its responsibilities; the restrictions on this authority are all explicitly listed in this constitution. | ||
| The SC may make a decision to revoke delegation of a specific part of authority, if necessary — even if the authority in question has been with a certain team since before the current constitution. |
There was a problem hiding this comment.
GitHub renders this visually as two paragraphs in the side by side view of the diff, while they are not.
This, in a way, reduces the reviewability.
There was a problem hiding this comment.
You mean the thing where it makes a table with every line, and so more wrapping in one cell means vertical blank space in the other cell?
Yes it does do that, but it didn't really feel like "two paragraphs" to me, just line-based tabling.
JulienMalka
left a comment
JulienMalka
left a comment
There was a problem hiding this comment.
I'm okay with the spirit of this change, I have verified this is a no-op, I don't care too much about the details.
I'd put the drafting notes in contributing.md, but again, I'm not going to bikeshed this.
The reason for this is given in the new section of `CONTRIBUTING.md`. Co-authored-by: Michael Daniels <mdaniels5757@gmail.com>
Ericson2314
force-pushed
the
one-sentence-per-line
branch
from
6e235d3 to
a5b848b
Compare
I already also came to the conclusion that that is better location than where I originally put it. Since @JulienMalka agrees, and no one else weighed in against this, I moved it there. |
philiptaron
left a comment
philiptaron
left a comment
There was a problem hiding this comment.
For sure, let's do it.
|
We have unanimity! |
9 participants
The reason for this is given in the new section of the read-me.