rulesets/nixpkgs: Allow create-pull-request prefix branches #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 28, 2025
For workflows that create Nixpkgs pull requests. Co-authored-by: Wolfgang Walther <walther@technowledgy.de>
wolfgangwalther
force-pushed
the
allow-nixpkgs-cpr-branches
branch
from
ff1c28b to
6f7bc10
Compare
Contributor
wolfgangwalther
left a comment
wolfgangwalther
left a comment
There was a problem hiding this comment.
To avoid accidental collisions, we should limit this namespace to automation, not regular committers. Regular committers can use wip-. I added a separate rule to do this.
wolfgangwalther
approved these changes
Oct 28, 2025
Contributor
wolfgangwalther
left a comment
wolfgangwalther
left a comment
There was a problem hiding this comment.
I implemented this with my own feedback addressed.
Comment on lines
+34
to
+35
| "created_at": "2025-06-11T20:44:19.501+02:00", | ||
| "updated_at": "2025-10-28T09:52:46.205+01:00", |
Contributor
There was a problem hiding this comment.
Note: The diff for created_at is stupid. We should make this script do UTC instead - or remove the created_at / updated_at fields entirely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For workflows that create Nixpkgs pull requests. See NixOS/nixpkgs#450864 (comment)