Skip to content

mftrace: patch for GCC15 to fix linux build#503280

Merged
mdaniels5757 merged 1 commit intoNixOS:masterfrom
chrjabs:push-upwowzrvvwry
Mar 28, 2026
Merged

mftrace: patch for GCC15 to fix linux build#503280
mdaniels5757 merged 1 commit intoNixOS:masterfrom
chrjabs:push-upwowzrvvwry

Conversation

@chrjabs
Copy link
Copy Markdown
Contributor

@chrjabs chrjabs commented Mar 25, 2026

Build failed because the source is redefining bool as an enum with true and false as variants, but they are keywords since C23.
See #475479.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci bot requested a review from xworld21 March 25, 2026 07:49
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Mar 25, 2026
@chrjabs

This comment was marked as outdated.

@chrjabs chrjabs force-pushed the push-upwowzrvvwry branch from 02519aa to 1a7f056 Compare March 26, 2026 08:38
@chrjabs chrjabs force-pushed the push-upwowzrvvwry branch from 1a7f056 to 9fd154c Compare March 26, 2026 08:39
@chrjabs chrjabs changed the title mftrace: set C17 to fix linux build mftrace: patch for GCC15 to fix linux build Mar 26, 2026
@chrjabs
Copy link
Copy Markdown
Contributor Author

chrjabs commented Mar 26, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 503280
Commit: 9fd154c7a912aa44ebb78b1672421fff9169779e


x86_64-linux

✅ 1 package built:
  • mftrace

aarch64-linux

✅ 1 package built:
  • mftrace

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Mar 26, 2026
@mdaniels5757
Copy link
Copy Markdown
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 503280
Commit: 9fd154c7a912aa44ebb78b1672421fff9169779e (subsequent changes)
Merge: cd34b9fae8fc1f26a7660250689b8ec34c0d0e77

Logs: https://github.com/mdaniels5757/nixpkgs-review-gha/actions/runs/23675918125

Download packages from cache:
  • x86_64-linux
    nix-store -r --add-root nixpkgs-pr-503280-x86_64-linux \
      --option binary-caches 'https://cache.nixos.org/ https://mdaniels5757-nix.cachix.org' \
      --option trusted-public-keys '
      cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
      mdaniels5757-nix.cachix.org-1:iT2D2XMbTS301DFoC8sTOSP86fXMPiGrvPnrEsQN5uo=
      ' \
      /nix/store/h3bwl301k84sxgk8mjwc8a3dxhxy440h-mftrace-1.2.20
  • aarch64-linux
    nix-store -r --add-root nixpkgs-pr-503280-aarch64-linux \
      --option binary-caches 'https://cache.nixos.org/ https://mdaniels5757-nix.cachix.org' \
      --option trusted-public-keys '
      cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
      mdaniels5757-nix.cachix.org-1:iT2D2XMbTS301DFoC8sTOSP86fXMPiGrvPnrEsQN5uo=
      ' \
      /nix/store/j1qb3r6cj48q6mmr4aighmp6ddxy07i2-mftrace-1.2.20
  • x86_64-darwin
    nix-store -r --add-root nixpkgs-pr-503280-x86_64-darwin \
      --option binary-caches 'https://cache.nixos.org/ https://mdaniels5757-nix.cachix.org' \
      --option trusted-public-keys '
      cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
      mdaniels5757-nix.cachix.org-1:iT2D2XMbTS301DFoC8sTOSP86fXMPiGrvPnrEsQN5uo=
      ' \
      /nix/store/9767pjq75y6qc6d0rjzl9mm0c510dccq-mftrace-1.2.20
  • aarch64-darwin
    nix-store -r --add-root nixpkgs-pr-503280-aarch64-darwin \
      --option binary-caches 'https://cache.nixos.org/ https://mdaniels5757-nix.cachix.org' \
      --option trusted-public-keys '
      cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
      mdaniels5757-nix.cachix.org-1:iT2D2XMbTS301DFoC8sTOSP86fXMPiGrvPnrEsQN5uo=
      ' \
      /nix/store/ps4bdr32wij7rm3xkmykwrpfqgrh11jq-mftrace-1.2.20

x86_64-linux

✅ 1 package built:
  • mftrace

aarch64-linux

✅ 1 package built:
  • mftrace

x86_64-darwin (sandbox = relaxed)

✅ 1 package built:
  • mftrace

aarch64-darwin (sandbox = relaxed)

✅ 1 package built:
  • mftrace

Copy link
Copy Markdown
Member

@mdaniels5757 mdaniels5757 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

@mdaniels5757 mdaniels5757 added this pull request to the merge queue Mar 28, 2026
Merged via the queue into NixOS:master with commit 144bea7 Mar 28, 2026
33 of 35 checks passed
@chrjabs chrjabs deleted the push-upwowzrvvwry branch April 1, 2026 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants