nixos/installer/cd-dvd/iso-image: Allow booting on CHRP machines#488831
Draft
OPNA2608 wants to merge 1 commit intoNixOS:masterfrom
Draft
nixos/installer/cd-dvd/iso-image: Allow booting on CHRP machines#488831OPNA2608 wants to merge 1 commit intoNixOS:masterfrom
OPNA2608 wants to merge 1 commit intoNixOS:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...& New World ROM Macs
Must be built on powerpc64-linux, cross is blocked by at least:
Needs:
WIP.
systemd[1]: Started Journal Service..nixos/modules/installer/cd-dvd/ppm2osbadgeicon.cis a custom tool I hacked together for customising the image displayed in the graphical boot selector on New World ROM Macs, see image above. The default image from GRUB's CHRP script is the GNU logo. I wanted to differentiate the icon for the installer from the icon of the already-installed Debian system (which uses the GRUB default).If this is deemed useful, I can throw the code into a separate repo and package it so we don't need to vendor it. If this customisation is deemed too much, that's also fine.
flake.ppm(pride flake logo), because the image produced byimagemagickon hardware has a tint added to the entire result that results in wrong colours (convertingnix-snowflake.svgmakes it look more like the old blue-purple colour scheme). Would like to drop this and instead generate it, but shipping weird colours./ppc/bootinfo.txt) is mostly copied from GRUB. Would like to eventually generate both the CHRPbootinfo.txtand the New World ROM MacBootXfile from an attrset with format-specific adjustments made to it (different SGML tags & formats used for the boot menu icon, different tag capitalisation requirements).Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.