Skip to content

Comments

python3Packages.exceptiongroup: fix build on staging#487915

Merged
mweinelt merged 1 commit intoNixOS:stagingfrom
thunze:exceptiongroup-fix-repr
Feb 8, 2026
Merged

python3Packages.exceptiongroup: fix build on staging#487915
mweinelt merged 1 commit intoNixOS:stagingfrom
thunze:exceptiongroup-fix-repr

Conversation

@thunze
Copy link
Member

@thunze thunze commented Feb 7, 2026 •
edited
Loading

python313Packages.exceptiongroup currently fails to build on staging.

Reason: CPython fixed python/cpython#141732 in python/cpython#141736, but exceptiongroup 1.3.1, including its test suite, still matches the old repr behavior. The CPython fix has only been backported to 3.13 so far, where it was first included in version 3.13.12, so we only need to patch for 3.13 and 3.15+ at the moment.

I verified that exceptiongroup builds on Python 3.12+.

Upstream issue: agronholm/exceptiongroup#154

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@thunze thunze force-pushed the exceptiongroup-fix-repr branch from ea6a5d3 to 60588ad Compare February 7, 2026 11:08
@nixpkgs-ci nixpkgs-ci bot requested a review from fabaff February 7, 2026 11:17
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 6.topic: python Python is a high-level, general-purpose programming language. labels Feb 7, 2026
@dotlambda
Copy link
Member

dotlambda commented Feb 7, 2026

The CPython fix has only been backported to 3.13 so far, where it was first included in version 3.13.12, so we only need to patch for 3.13 and 3.15+ at the moment.

It wasn't backported to 3.14?

@thunze
Copy link
Member Author

thunze commented Feb 7, 2026 •
edited
Loading

It wasn't backported to 3.14?

Not yet: python/cpython#142388; also python/cpython#144445

@bengsparks
Copy link
Contributor

bengsparks commented Feb 7, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 487915 --package python315Packages.exceptiongroup --package python313Packages.exceptiongroup --package python314Packages.exceptiongroup
Commit: 60588ada4ae315f44415d1bca625c1cb853c5e68

aarch64-darwin

✅ 6 packages built:
  • python313Packages.exceptiongroup
  • python313Packages.exceptiongroup.dist (python313Packages.exceptiongroup.dist.dist)
  • python314Packages.exceptiongroup
  • python314Packages.exceptiongroup.dist (python314Packages.exceptiongroup.dist.dist)
  • python315Packages.exceptiongroup
  • python315Packages.exceptiongroup.dist (python315Packages.exceptiongroup.dist.dist)

@bengsparks
Copy link
Contributor

bengsparks commented Feb 7, 2026

Approved for the current state of Python. Hopefully Python will backport to 3.14 as well, otherwise that would be odd.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 7, 2026
@bengsparks bengsparks mentioned this pull request Feb 7, 2026
Merged
13 tasks
@mweinelt
Copy link
Member

mweinelt commented Feb 7, 2026

Please file an issue upstream at the exceptiongroup backports module repo.

@thunze
Copy link
Member Author

thunze commented Feb 7, 2026

Upstream issue: agronholm/exceptiongroup#154

@thunze thunze force-pushed the exceptiongroup-fix-repr branch from 60588ad to ede0572 Compare February 7, 2026 16:21
@mweinelt
Copy link
Member

mweinelt commented Feb 7, 2026

The on staging part of the commit message is not really meaningful and should be removed.

@mweinelt
Copy link
Member

mweinelt commented Feb 8, 2026

@thunze: fix build after cpython changes

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Feb 8, 2026
@thunze @mweinelt
python3Packages.exceptiongroup: fix build after cpython repr changes
294b175 
CPython fixed python/cpython#141732 in
python/cpython#141736, but exceptiongroup 1.3.1,
including its test suite, still matches the old repr behavior.
The CPython fix has only been backported to 3.13 so far, where it was
first included in version 3.13.12, so we only need to patch for 3.13
and 3.15+.

Upstream issue: agronholm/exceptiongroup#154
@mweinelt mweinelt force-pushed the exceptiongroup-fix-repr branch from ede0572 to 294b175 Compare February 8, 2026 16:01
@thunze
Copy link
Member Author

thunze commented Feb 8, 2026

The on staging part of the commit message is not really meaningful and should be removed.

@thunze: fix build after cpython changes

Noted, thanks! :)

@mweinelt mweinelt added this pull request to the merge queue Feb 8, 2026
Merged via the queue into NixOS:staging with commit 37e740a Feb 8, 2026
25 checks passed
@thunze thunze deleted the exceptiongroup-fix-repr branch February 8, 2026 17:02
@h0nIg
Copy link
Contributor

h0nIg commented Feb 14, 2026

Is this required to get backported to 25.11 as well?

@dotlambda dotlambda added the backport staging-25.11 Backport PR automatically label Feb 14, 2026
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Feb 14, 2026

Successfully created backport PR for staging-25.11:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Feb 14, 2026
Open
@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Feb 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Prince213 Prince213 Prince213 left review comments

@mweinelt mweinelt mweinelt approved these changes

@fabaff fabaff Awaiting requested review from fabaff

+1 more reviewer

@bengsparks bengsparks bengsparks approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.approvals: 2 This PR was reviewed and approved by two persons. backport staging-25.11 Backport PR automatically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@thunze @dotlambda @bengsparks @mweinelt @h0nIg @Prince213