Skip to content

dsview: fix build with cmake 4 #454119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bachp merged 1 commit into from
Oct 23, 2025
Merged

dsview: fix build with cmake 4 #454119

bachp merged 1 commit into from
Oct 23, 2025
+14 −0

Conversation

@carlossless
Copy link
Contributor

@carlossless carlossless commented Oct 21, 2025 •
edited
Loading

Fixes build failure caused by cmake 4 (#445447)

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 21, 2025
@carlossless
Copy link
Contributor Author

carlossless commented Oct 21, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 454119
Commit: e687f1f5936fa6123c07e2dbf010c3f6b61a64dd

x86_64-linux

✅ 1 package built:
  • dsview

aarch64-linux

✅ 1 package built:
  • dsview

x86_64-darwin

✅ 1 package built:
  • dsview

aarch64-darwin

✅ 1 package built:
  • dsview

@carlossless carlossless marked this pull request as ready for review October 21, 2025 09:14
@nix-owners nix-owners bot requested a review from bachp October 21, 2025 09:15
@Sigmanificient Sigmanificient mentioned this pull request Oct 21, 2025
Open
@bachp bachp added this pull request to the merge queue Oct 23, 2025
@bachp
Copy link
Member

bachp commented Oct 23, 2025

Submited upstream: DreamSourceLab/DSView#886

Merged via the queue into NixOS:master with commit 4d06045 Oct 23, 2025
40 of 43 checks passed
@carlossless carlossless deleted the packages/dsview/cmake4-fix branch October 23, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bachp bachp Awaiting requested review from bachp

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@carlossless @bachp