python3Packages.pyroaring: 1.0.2 -> 1.0.3#450330
python3Packages.pyroaring: 1.0.2 -> 1.0.3#450330SuperSandro2000 merged 1 commit intoNixOS:masterfrom
Conversation
873114b to
aa25b52
Compare
aa25b52 to
a021303
Compare
|
a021303 to
807cf9a
Compare
807cf9a to
33fd07f
Compare
|
Re-running CI due to a since-fixed unrelated treefmt-nix failure |
381fd53 to
a6d2b37
Compare
|
|
@Sigmanificient This PR will fail until #450036 is merged. |
|
@shymega if you want to include the changelog, can you then link TO the changelog instead in the future? Right now you're pinging and tagging issues/PRs, which doesn't make any sense. |
This is not technically a revert as we use it in nixpkgs. 😅 The change itself is and was good but it is being removed as part of the upgrade. I squashed the commits together. |
a6d2b37 to
b63348f
Compare
b63348f to
a0d0745
Compare
|
@eyJhb Noted, apologies for this. Can I suggest this is explicit in the template for PRs, to avoid any further occurrences? I could submit a PR for that, if that works. |
@SuperSandro2000 Thanks :) |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-25.05
git worktree add -d .worktree/backport-450330-to-release-25.05 origin/release-25.05
cd .worktree/backport-450330-to-release-25.05
git switch --create backport-450330-to-release-25.05
git cherry-pick -x a0d07454dfd46d18524261e0879d449482f517ab |
Hm. Never seen this before. How would one deal with an issue like this - would I have to defer to a Nixpkgs committer? |
|
It's because 25.05 is on 1.0.0 currently, so there's a merge conflict. The solution is to cherry-pick the upgrades that happened in between, then the new one. I'll do so, and then a committer can merge it. (The alternate way, which would allow a maintainer to merge it if this package was in |
Bump
pyroaringto v1.0.3, and revert c92de0a., aspyroaringv1.0.3 fixes the need for that commit.pyroaringchangelog:Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.