python3Packages.{kokoro, misaki}: init at 0-unstable-2025-06-16 #417378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
10.rebuild-darwin: 0
Member
Author
|
kokoro works for me when running in a nix-shell with eg running the kokoro README usage example in this shell works. |
Bot-wxt1221
reviewed
Jun 17, 2025
Bot-wxt1221
reviewed
Jun 17, 2025
Bot-wxt1221
reviewed
Jun 17, 2025
Prince213
requested changes
Jun 18, 2025
Member
Prince213
left a comment
Prince213
left a comment
There was a problem hiding this comment.
- Uses of
pnameforreposhould be avoided (#277994) - Consequently unnecessary
recshould be removed fetchpatchshould be replaced byfetchpatch2(https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#fetching-patches)
Prince213
requested changes
Jun 20, 2025
Member
Prince213
left a comment
Prince213
left a comment
There was a problem hiding this comment.
Please make sure to read relevant docs before you make any changes.
dotlambda
reviewed
Jun 21, 2025
Member
Author
|
I'll merge tomorrow unless anyone objects? |
dotlambda
reviewed
Jun 25, 2025
| ]; | ||
|
|
||
| # See https://github.com/hexgrad/misaki/blob/main/pyproject.toml#L26 | ||
| passthru.optional-dependencies = { |
Member
There was a problem hiding this comment.
Suggested change
| passthru.optional-dependencies = { | |
| optional-dependencies = |
| }; | ||
|
|
||
| # Package does not have tests as of 2025-06-16, but phonemizer is required for | ||
| # pythonImportsCheck. |
Member
There was a problem hiding this comment.
Shouldn't it be in upstream's dependencies then?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.