Skip to content

[Backport release-25.05]: cromite: 135.0.7049.100 -> 137.0.7151.72 #415944

Merged
LeSuisse merged 3 commits intoNixOS:release-25.05from
JohnRTitor:backport-415840-to-release-25.05
Jun 11, 2025
Merged

[Backport release-25.05]: cromite: 135.0.7049.100 -> 137.0.7151.72 #415944
LeSuisse merged 3 commits intoNixOS:release-25.05from
JohnRTitor:backport-415840-to-release-25.05

Conversation

@JohnRTitor
Copy link
Member

@JohnRTitor JohnRTitor commented Jun 11, 2025 •
edited
Loading

Backport of #403794, #412893, #415840

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

emaryn and others added 3 commits June 12, 2025 01:39
@JohnRTitor JohnRTitor requested a review from LeSuisse June 11, 2025 20:11
@github-actions github-actions bot added 4.workflow: backport This targets a stable branch 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 11, 2025
@nix-owners nix-owners bot requested a review from a user June 11, 2025 20:17
@LeSuisse LeSuisse added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Jun 11, 2025
LeSuisse
LeSuisse approved these changes Jun 11, 2025
View reviewed changes
Copy link
Member

@LeSuisse LeSuisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Browsed a few pages with it, seems fine.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 415944
Commit: 44ed88a52cebd409772c075e79c5d288a8416f48

x86_64-linux

✅ 1 package built:
  • cromite

@LeSuisse LeSuisse merged commit 508ecaf into NixOS:release-25.05 Jun 11, 2025
17 of 20 checks passed
@ghost ghost removed their request for review June 12, 2025 15:58
@JohnRTitor JohnRTitor deleted the backport-415840-to-release-25.05 branch June 12, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LeSuisse LeSuisse LeSuisse approved these changes

Assignees

No one assigned

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 4.workflow: backport This targets a stable branch 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JohnRTitor @LeSuisse @r-ryantm