-
-
Notifications
You must be signed in to change notification settings - Fork 17.9k
fix kmscon module #391574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix kmscon module #391574
Conversation
|
As per fbcon fashion, there's rendering issues. I guess the PR will get much more complicated if this doesn't turn out to be a fluke. |
|
Ok, this might just be a greetd issue I'm having. Either way, it would be great if someone would test this under "normal" circumstances |
|
Enabled with GNOME and it seems to work like it used to. Didn’t test extensively, but at least GDM is able to start now. |
|
Yeah, I suspect the current rev we're in actually works as intended and we actually have to disable DRM specifically. There also is the option to patch kmscon to allow it to free the gpu on demand. However, we would also have to modify every single derivation that starts a graphical session or needs /dev/dri/cardX so it also tells kmscon to free the GPU, just so we use DRM for kmscon (and I don't know any benefits of using DRM over fbcon for kmscon) |
|
how do i undo this git has played me |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/5352 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Graphical sessions do launch, but I’ve noticed both PipeWire and 3D acceleration don’t seem to work properly. PipeWire only shows the dummy output, even though the service is running and WirePlumber works, 3D acceleration works in X11 but not Wayland apps.
|
This is the same whether I use DRM or no-drm, hwaccel or no-hwaccel in configuration |
|
hwaccel is supposed to be for drawing kmscon only. If you run under kmscon, you have to wrap your graphical sessions with kmscon-launch-gui sway |
I get these kinds of errors when launching e.g. Anki or Firefox and using Wayland. When using X11, video acceleration works, and the compositor itself seems to have GPU access, but only when I use seatd. If I try to use logind instead it doesn’t launch. This is something to do with the way Nix is launching kmscon I think |
|
Also could be seat-related. Kmscon is starting to get a much needed facelift |
|
Please rebase this on latest master, I'd love to see it merged |
ccicnce113424
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pressing the Backspace key did not move the cursor backward. Furthermore, the following error appeared after logging in:
/nix/store/qm7yzix9jc0bwmBkOvw5Bbbnad99kiyl-set-environment:36: can't find terminal definition for $TERM
/nix/store/qm7yzix9jc0bwmBkOvw5Bbbnad99kiyl-set-environment:56: can't find terminal definition for $TERM
|
That's strange considering i copied the service verbatim. I don't have the issue on agetty. What's your setup? |
This seems to occur only when the user's default shell is zsh. |
|
I'm using zsh too and it's working well for me when the VT is opened first time, which covers 90% of my use. But if I open another VT and then I go back into an already open VT:
However both problems still exist when I don't use this PR, so it looks like an upstream issue. |
After applying #483176, it no longer occurs. |
Things done
Adjusted the systemd unit for kmscon to fix #385497
This however will completely disable DRM for kmscon and now seats will be unspecified.
If someone absolutely requires DRM for kmscon, let me know.
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.