Skip to content

vscode-extensions.vadimcn.vscode-lldb.adapter: fix LLDB_DEBUGSERVER_PATH for darwin#388192

Closed
r4v3n6101 wants to merge 2 commits intoNixOS:masterfrom
r4v3n6101:vscode-lldb-adapter
Closed

vscode-extensions.vadimcn.vscode-lldb.adapter: fix LLDB_DEBUGSERVER_PATH for darwin#388192
r4v3n6101 wants to merge 2 commits intoNixOS:masterfrom
r4v3n6101:vscode-lldb-adapter

Conversation

@r4v3n6101
Copy link
Contributor

@r4v3n6101 r4v3n6101 commented Mar 8, 2025

MacOS doesn't work with the provided lldb debugger. Instead it requires signed XCode debugger.
#211321 doesn't fix it in the adapter package

Resolves #387776

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Mar 8, 2025
@github-actions github-actions bot added 6.topic: vscode A free and versatile code editor that supports almost every major programming language. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Mar 8, 2025
@r4v3n6101 r4v3n6101 force-pushed the vscode-lldb-adapter branch 2 times, most recently from 9c98872 to 7049a5c Compare March 8, 2025 13:00
@github-actions github-actions bot added 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Mar 8, 2025
@r4v3n6101 r4v3n6101 force-pushed the vscode-lldb-adapter branch from 7049a5c to d304789 Compare March 8, 2025 22:47
@github-actions github-actions bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 8, 2025
@r4v3n6101
Copy link
Contributor Author

r4v3n6101 commented Mar 11, 2025

I've added myself as the maintainer as discussed here: #387776

@r4v3n6101
Copy link
Contributor Author

@NixOS/nixpkgs-merge-bot merge

@nixpkgs-merge-bot
Copy link
Contributor

@r4v3n6101 merge not permitted (#305350):
pkgs/applications/editors/vscode/extensions/vadimcn.vscode-lldb/adapter.nix is not in pkgs/by-name/
pkgs/applications/editors/vscode/extensions/vadimcn.vscode-lldb/default.nix is not in pkgs/by-name/

@r4v3n6101
Copy link
Contributor Author

I don't want whom should I write to further. Hope someone ping helps
@NixOS/nixpkgs-committers

@NickCao
Copy link
Member

NickCao commented Mar 14, 2025

I don't want whom should I write to further. Hope someone ping helps @NixOS/nixpkgs-committers

Hey, this pings like two hundred people, please refrain from doing this next time. Please use the discourse thread: https://discourse.nixos.org/t/prs-ready-for-review/3032/1

@emilazy
Copy link
Member

emilazy commented Mar 14, 2025

There’s hundreds of people subscribed to this PR now and we can’t automatically unsubscribe them all, please open a new PR.

@NixOS NixOS locked as spam and limited conversation to collaborators Mar 14, 2025
@emilazy emilazy closed this Mar 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

6.topic: darwin Running or building packages on Darwin 6.topic: vscode A free and versatile code editor that supports almost every major programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vscode-extensions.vadimcn.vscode-lldb: MacOS doesn't see debugserver

4 participants

Comments