zen-browser: init at 1.19.1b by Eveeifyeve · Pull Request #363992 · NixOS/nixpkgs

Eveeifyeve · 2024-12-10T17:41:54Z

NOTE: This package takes quite a lot of resources to build. It took me an hour maybe two on my machine (3200g), This is not a package you want to compile yourself if you can avoid it.

If anyone wants to be added as a maintainer to this package, please leave a comment and I will add you.

Followup from PR #347222 that got reverted because of this comment: #347222 (comment) I want to make sure this pr is okay to go on nixpkgs the right way instead of reverting.

Closes #327982

Tracking:

Zen browser to keep a stable with security vulenabilitys & Approval from @winterqt, @emilazy & @mweinelt read more about it here as I am not going to repeat myself anymore.
Add one active committer from nixpkgs
Use buildMozillaMach
Patch all of the git usages.
Figure out a nix-community nixpkgs fork so zen-browser can build on their hydra and people can use the fork.

If wanting to talk please talk in here if you want to contribute or preferably the matrix nix Mozilla chat.

I will not be accepting comments that aren't contributing to this pr directly and will be marked off-topic by moderation it is wasting time on contributors who want to work on this pr.

This work is semi-sponsored by DigitalBrewStudios.

Things done

Add a 👍 reaction to pull requests you find important.

Eveeifyeve · 2024-12-10T17:46:10Z

I will need to fix the update script to update surfer and firefox.

winterqt · 2024-12-10T17:46:31Z

I want to make sure this pr is okay to go on nixpkgs the right way instead of reverting.

The PR had not only had technical issues, but project management issues inherent to upstream as well. As such, drafting until a consensus amongst committees/security/buildMozillaMach folks can be reached.

winterqt · 2024-12-10T18:19:05Z

pkgs/by-name/ze/zen-browser-unwrapped/package.nix

Looking at Surfer's code, it seems to be quite simple just to patch out the Git usages, even being able to contribute most (if not all) of these fixes upstream. Can we try that?

Yeah I could look at doing that.

There are a lot of git uses though: https://github.com/search?q=repo%3Azen-browser%2Fsurfer+%27git%27&type=code

~~I have NodeJS experience and could sumit a patch to use isomorphic-git instead to remove the git dependency if that would be helpful.~~ Never mind, it doesn't support some git commands that are needed.

There are a lot of git uses though

Most of them are not relevant to us, so we can ignore them. On a cursory glance, I count three that we'd want to patch:

https://github.com/zen-browser/surfer/blob/ecd6b650f0234402976dde7e775d42aec6568406/src/commands/patches/git-patch.ts#L16-L18

https://github.com/zen-browser/surfer/blob/ecd6b650f0234402976dde7e775d42aec6568406/src/commands/build.ts#L34

https://github.com/zen-browser/surfer/blob/ecd6b650f0234402976dde7e775d42aec6568406/src/commands/download/addon.ts#L223-L230 (if Zen even uses addons)

I've just worked on two patches that patch the addon one and the changeset in build. But I am having a bit of trouble of patching the git patch one as that uses the patches from zen browser and applies it directly to the engine.

~~Unless a. use IFD which is against nixpkgs or b. include every patch in diretory.~~ it turns out that this is not IFD if it was it would ofborg would eval error + gh actions.

This is still the case with updated code I am looking into solutions.

And I am actually encouraging for people to add their work to my branch and to spit this up into seperate prs in my branch so this can get merged with the more work.

@winterqt I do want to patch this however are you sure on what patches it applies to the source?

winterqt · 2024-12-14T16:47:40Z

You would need to provide an example of a library in question, the error you run into, and why you think it's needed on Darwin.

Pandapip1 · 2024-12-14T20:19:36Z

Working on darwin support, but a lot of libraries used that are linux based, is there an easier route of finding out what is using a linux thing directly.

You could run readelf -d </path/to/binary>

DADA30000 · 2026-02-03T16:45:07Z

why pgo is disabled?

Working on this again! I can't seem to find a way where I can apply patches directly from source zenbrowser and surfer. Does any zen maintainer in a comment can tell me the steps that surfer goes through, because in order to get this out it needs to not rely on surfer?
CC @mr-cheffy

maybe like just run find that finds .patch files and executes patch in engine dir for each of them?

It's not just the .patch it has turned out more complicated.

ah, yeah, I can see, there are also prefs and other stuff

Eveeifyeve · 2026-03-06T12:48:57Z

Sorry I have been inactive on this pr, I will be trying to get surfer issues that are mentioned in the comments here. Just reverted my source patching so this is at least working state. ~~I will update this to latest in a sec.~~ Updated.

I am rethinking this a different way, to not over-complicate things while being a FOD (eg. patch all the git usages for now just to get this out).

I know it has been a year, pr's like these take a long time, I am working my absolute best to get this out now thanks to a couple pr's out of the way, please be more patient.

why pgo is disabled?

Does zen-browser even have support for pgo?

pkgs/by-name/ze/zen-browser/package.nix

yzhou216 · 2026-03-10T21:07:03Z

pkgs/by-name/ze/zen-browser/package.nix

+    pname = "surfer-patched";
+    version = "0-unstable-2026-01-25";
+
+    src = fetchFromGitHub {


Does the update script update this?

No, I have to change this. I just haven't had time. Also thank you for the reviews they are tiny nitpicks, I would like to remind of this guideline in the readme: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#a-reviewer-requested-a-bunch-of-insubstantial-changes to avoid getting into trouble. I will get around to responding to your nitpicks on the weekend, as I have school.

UPDATE: I have responded to all of those nitpicks sept for the update script since I had spear time from school, I will do the update script this weekend since I have co-curricular activity's (school and non-school) and school.

UPDATE: I didn't quite get my head around to fixing this (I have, but I haven't), But I am still working on this.

pkgs/by-name/ze/zen-browser/package.nix

Co-authored-by: Matthew Penner <me@matthewp.io> Co-authored-by: Ruby Iris Juric <ruby@srxl.me> Co-authored-by: Yiyu Zhou <yiyuzhou19@gmail.com>

Eveeifyeve self-assigned this Dec 10, 2024

winterqt marked this pull request as draft December 10, 2024 17:46

This comment was marked as spam.

Sign in to view

github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 10, 2024

This comment was marked as outdated.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as outdated.

Sign in to view

winterqt requested changes Dec 10, 2024

View reviewed changes

DOD-101 mentioned this pull request Dec 10, 2024

zen-browser: add module nix-community/home-manager#6012

Closed

6 tasks

ofborg bot added the 8.has: package (new) This PR adds a new package label Dec 11, 2024

ofborg bot requested review from Titaniumtown and matthewpi December 11, 2024 13:29

ofborg bot added the 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. label Dec 11, 2024

This comment was marked as off-topic.

Sign in to view

This comment was marked as outdated.

Sign in to view

Eveeifyeve changed the title ~~zen-browser: init at 1.0.2-b.0~~ zen-browser: init at 1.0.2-b.3 Dec 20, 2024

Eveeifyeve force-pushed the zen-browser branch from 5094a94 to 66629b1 Compare December 20, 2024 00:59

github-actions bot removed the 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. label Dec 20, 2024

Eveeifyeve force-pushed the zen-browser branch 2 times, most recently from 72a2d56 to 8f31186 Compare December 20, 2024 05:07

ofborg bot added the 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. label Dec 20, 2024

Eveeifyeve force-pushed the zen-browser branch from 8f31186 to 10078c9 Compare December 24, 2024 12:38

github-actions bot removed the 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. label Dec 24, 2024

Eveeifyeve changed the title ~~zen-browser: init at 1.0.2-b.3~~ zen-browser: init at 1.0.2-b.4 Dec 24, 2024

Eveeifyeve mentioned this pull request Dec 24, 2024

Package request: Zen Browser #327982

Closed

Eveeifyeve force-pushed the zen-browser branch from 93066cf to 70de708 Compare March 6, 2026 12:48

Eveeifyeve changed the title ~~zen-browser: init at 1.12.5b~~ zen-browser: init at 1.19.1b Mar 6, 2026

Eveeifyeve force-pushed the zen-browser branch from 70de708 to 753a48b Compare March 6, 2026 13:04

yzhou216 reviewed Mar 8, 2026

View reviewed changes

pkgs/by-name/ze/zen-browser/package.nix Outdated Show resolved Hide resolved

Eveeifyeve force-pushed the zen-browser branch 3 times, most recently from d3fdac8 to 0edb990 Compare March 8, 2026 12:29

nixpkgs-ci bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Mar 8, 2026

Eveeifyeve force-pushed the zen-browser branch 2 times, most recently from 2ffa548 to 74dbe2c Compare March 8, 2026 13:04

Eveeifyeve force-pushed the zen-browser branch from 74dbe2c to 6e55f73 Compare March 8, 2026 13:40

yzhou216 reviewed Mar 9, 2026

View reviewed changes

pkgs/by-name/ze/zen-browser/package.nix Outdated Show resolved Hide resolved

pkgs/by-name/ze/zen-browser/package.nix Show resolved Hide resolved

Eveeifyeve force-pushed the zen-browser branch from 6e55f73 to e75c68d Compare March 10, 2026 07:16

yzhou216 reviewed Mar 10, 2026

View reviewed changes

Eveeifyeve force-pushed the zen-browser branch 2 times, most recently from abd4b1c to 7592220 Compare March 15, 2026 03:41

yzhou216 reviewed Mar 15, 2026

View reviewed changes

pkgs/by-name/ze/zen-browser/package.nix Outdated Show resolved Hide resolved

Eveeifyeve force-pushed the zen-browser branch from 7592220 to 1b025bc Compare March 15, 2026 05:41

yzhou216 reviewed Mar 15, 2026

View reviewed changes

pkgs/by-name/ze/zen-browser/package.nix Outdated Show resolved Hide resolved

zen-browser: init at 1.19.1b

05d2529

Co-authored-by: Matthew Penner <me@matthewp.io> Co-authored-by: Ruby Iris Juric <ruby@srxl.me> Co-authored-by: Yiyu Zhou <yiyuzhou19@gmail.com>

Eveeifyeve force-pushed the zen-browser branch from 1b025bc to 05d2529 Compare March 15, 2026 06:48

Uh oh!

Conversation

Eveeifyeve commented Dec 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Tracking:

Things done

Uh oh!

Eveeifyeve commented Dec 10, 2024

Uh oh!

winterqt commented Dec 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as spam.

This comment was marked as outdated.

This comment was marked as off-topic.

This comment was marked as outdated.

winterqt Dec 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Eveeifyeve Dec 11, 2024

Choose a reason for hiding this comment

Uh oh!

Pandapip1 Dec 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

winterqt Dec 11, 2024

Choose a reason for hiding this comment

Uh oh!

Eveeifyeve Dec 20, 2024

Choose a reason for hiding this comment

Uh oh!

Eveeifyeve Dec 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Eveeifyeve May 18, 2025

Choose a reason for hiding this comment

Uh oh!

Eveeifyeve Sep 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Eveeifyeve Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

This comment was marked as off-topic.

winterqt commented Dec 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Pandapip1 commented Dec 14, 2024

Uh oh!

This comment was marked as outdated.

DADA30000 commented Feb 3, 2026

Uh oh!

Eveeifyeve commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yzhou216 Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

Eveeifyeve Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Eveeifyeve Mar 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Eveeifyeve commented Dec 10, 2024 •

edited

Loading

winterqt commented Dec 10, 2024 •

edited

Loading

winterqt Dec 10, 2024 •

edited

Loading

Pandapip1 Dec 11, 2024 •

edited

Loading

Eveeifyeve Dec 20, 2024 •

edited

Loading

Eveeifyeve Sep 6, 2025 •

edited

Loading

winterqt commented Dec 14, 2024 •

edited

Loading

Eveeifyeve commented Mar 6, 2026 •

edited

Loading

Eveeifyeve Mar 10, 2026 •

edited

Loading

Eveeifyeve Mar 15, 2026 •

edited

Loading