Skip to content

Conversation

@daniel-fahey
Copy link
Contributor

@daniel-fahey daniel-fahey commented Feb 21, 2024

Description of changes

CUPS filter and PPDs for various Labelife-compatible thermal label printers.

Supported printer models include:

  • D520 & D520BT
  • PM-201
  • PM-241 & PM-241-BT
  • PM-246 & PM-246S

Brands using Labelife drivers include:

  • Phomemo
  • Itari
  • Omezizy
  • Aimo

I have contacted Labelife re: permission to redistribute their unfree driver.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Tested with PM-241-BT: printer works successfully
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: printing Drivers, CUPS & Co. label Feb 21, 2024
@NixOSInfra NixOSInfra added the 12.first-time contribution This PR is the author's first one; please be gentle! label Feb 21, 2024
@daniel-fahey daniel-fahey force-pushed the cups-phomemo branch 2 times, most recently from 12c23f5 to a4ab10c Compare February 21, 2024 17:05
@github-actions github-actions bot removed the 6.topic: printing Drivers, CUPS & Co. label Feb 21, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Feb 21, 2024
@daniel-fahey daniel-fahey force-pushed the cups-phomemo branch 3 times, most recently from c424db4 to 534e1d6 Compare March 15, 2024 11:01
@daniel-fahey daniel-fahey changed the title cups-phomemo: init at 1.2.1 labelife-label-printer: init at 1.2.1 Mar 15, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/1016/102

Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi !

Thanks for your contribution.

I've left some comments, let me know if this is clear enough.

Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you <3

@drupol drupol merged commit 7a17610 into NixOS:master Mar 16, 2024
@daniel-fahey daniel-fahey deleted the cups-phomemo branch March 19, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants