apx: 1.8.2 -> 2.0.0

[chewblacka]

Description of changes

• Updated from 1.8.2 to 2.0.0 (https://github.com/Vanilla-OS/apx/releases/tag/v2.0.0)
• Removed dependency on docker (user must install docker or podman)
• Changed default config to match upstream
• Added myself to maintainers
• Wasn't picking up config file. Fixed by @NickCao
• Closes Update request: apx 1.8.2 → 2.0.0 #265938 & apx is not working on NixOS #249727

Ping @LennyLizowzskiy for testing

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[NickCao]

overall LGTM, still missing a fix for #249727 though.

[chewblacka]

overall LGTM, still missing a fix for #249727 though.

I only got that error with the previous version (1.8.2) which seemed to be broken. I don't know what the issue was, but upgrading to 2.0.0 seems to fix it. At least I haven't encountered it since.

[NickCao]

I can partly reproduce the issue on my system:

/result/bin/apx --version
Unable to read config file:
        Config File "apx" Not Found in "[/home/nickcao/Projects/nixpkgs/config /home/nickcao/Projects/config /home/nickcao/.config/apx /etc/apx /usr/share/apx]"

Maybe you have some leftover configuration files?

[NickCao]

This helps:

--- a/pkgs/tools/package-management/apx/default.nix
+++ b/pkgs/tools/package-management/apx/default.nix
@@ -23,10 +23,13 @@ buildGoModule rec {
     substituteInPlace config/apx.json \
     --replace "/usr/share/apx/distrobox" "${distrobox}/bin/distrobox" \
     --replace "/usr/share/apx" "$out/bin/apx"
+
+    substituteInPlace settings/config.go \
+    --replace "/usr/share/apx/" "$out/share/apx/"
   '';

   postInstall = ''
-    install -D config/apx.json -t $out/etc/apx/
+    install -D config/apx.json -t $out/share/apx/
     install -D man/man1/apx.1 -t $out/man/man1/
   '';

[chewblacka]

This helps:

Thanks. I had a local config file installed which stopped me from realising the global config wasn't being picked up. Thanks for the fix - that works well! Have pushed the changes.

[NickCao]

Tested basic functionality following the instructions in Vanilla-OS/apx#261