droopy: Fix Python 3.9 compatiblity#145702
Merged
Profpatsch merged 3 commits intoNixOS:masterfrom Nov 21, 2021
Merged
Conversation
tpwrules
suggested changes
Nov 13, 2021
Contributor
tpwrules
left a comment
There was a problem hiding this comment.
This does not evaluate as written. nixpkgs-review is a great tool to verify that your PRs build properly before submitting them. It would be a good idea to use that in the future.
| url = "https://patch-diff.githubusercontent.com/raw/stackp/Droopy/pull/30.patch"; | ||
| sha256 = "Y6jBraKvVQAiScbvLwezSKeWY3vaAbhaNXEGNaItigQ="; | ||
| }) | ||
| (pkgs.fetchpatch { |
Contributor
There was a problem hiding this comment.
This should simply be fetchpatch.
Contributor
Author
Thanks, I was in a rush and figured this was so simple I could get away with it. Guess I learnt my lesson! Thanks for the suggestion of |
Member
|
Result of 1 package built:
|
Member
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Droopy has been broken since the update to Python 3.9. This change brings in the fairly trivial unmerged PR at stackp/Droopy#31, which adds compatibility.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)