-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat: builtins.readSymlink primop #15093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JustAGuyTryingHisBest
wants to merge
4
commits into
NixOS:master
Choose a base branch
from
JustAGuyTryingHisBest:read-symlink-primop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
f5d63dd
feat: builtins.readSymlink primop
JustAGuyTryingHisBest 048edd4
fix quotes
JustAGuyTryingHisBest 69ba166
Merge remote-tracking branch 'upstream/master' into read-symlink-primop
JustAGuyTryingHisBest cd0537e
builtins.readSymlink return Path
JustAGuyTryingHisBest File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
tests/functional/lang/eval-fail-readSymlink-not-a-symlink.err.exp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| error: filesystem error: read_symlink: not a symlink [/pwd/lang/readDir/bar] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| builtins.readSymlink ./readDir/bar |
11 changes: 11 additions & 0 deletions
11
tests/functional/lang/eval-fail-readSymlink-not-a-symlink.postprocess
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| # shellcheck shell=bash | ||
| set -euo pipefail | ||
| testcaseBasename=$1 | ||
|
|
||
| # Normalize platform-specific filesystem error messages | ||
| sed -i "$testcaseBasename.err" \ | ||
| -e 's/filesystem error: in read_symlink:/filesystem error: read_symlink:/' \ | ||
| -e 's/Invalid argument/not a symlink/' \ | ||
| -e 's/Not a symbolic link/not a symlink/' \ | ||
| -e 's/\["\([^"]*\)"\]/[\1]/' \ | ||
| ; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| { ldir = /pwd/lang/readDir/foo; linked = /pwd/lang/readDir/foo/git-hates-directories; } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| { | ||
| ldir = builtins.readSymlink ./readDir/ldir; | ||
| linked = builtins.readSymlink ./readDir/linked; | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit questionable whether this should return a path value or just the raw symlink as a string (without canonicalisation). If the former, maybe this function should be called
builtins.canonPathorbuiltins.resolvePathor whatever (and accept non-symlink paths as well).