Merged
Conversation
xokdvium
approved these changes
Dec 10, 2025
tomberek
approved these changes
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
MAKE_WRAPPER_CONSTRUCTORto not override special constructors #14741 (Ericson2314)RestrictedStore::addDependency#14729 (Ericson2314)||,&㦈 (roberth)nix hash convert#14720 (Ericson2314)nix path-infofollow the JSON guidelines #14708 (Ericson2314)storeDira part ofUnkeyedValidPathInfo#14707 (Ericson2314)--json-formatfornix path-info#14704 (Ericson2314)nix develop"gathering derivation environment" #14641 (Ericson2314)Setting<std::filesystem::path>andSetting<std::optional<std::filesystem::path>>specializations #14632 (edolstra)WorkerProto::Serialiseabstraction forDrvOutput#14631 (Ericson2314)std::filesystem::path#14617 (vinayakankugoyal)deepSeq, json: handle stack overflow, report list index #14613 (roberth)static_cast#14603 (Ericson2314)Derivation::type()#14600 (edef1c)listNarandMemorySourceAccessor::File#14598 (Ericson2314)nix registry resolvecommand #14595 (edolstra)builtins.fetchTreedoc's lists #14545 (Ericson2314)Hashnow has to beBase16#14536 (Ericson2314)nix develop#14530 (Ericson2314)DerivationOptions#14507 (Ericson2314)DerivationOptions#14506 (Ericson2314)ValidPathInfo,NarInfoJSON instances, but don't yet use in the CLI #14503 (Ericson2314)builtins.genericClosure: improve errors #14499 (roberth)DerivationandValidPathInfo#14493 (Ericson2314)git+from theurlattribute #14492 (edolstra)DerivationBuilderParamshave reference toBasicDerivation#14490 (Ericson2314)toRealPathtoLocalFSStore#14483 (Ericson2314)newinto a function on Exprs #14481 (Radvendii)DerivationOptionsJSON and clean up unit tests #14471 (Ericson2314)c_str()in the evaluator, and other cleanups #14444 (Ericson2314)ExprConcatStrings::eval#14443 (Ericson2314)PathInfo::fromJSONusing recent JSON utils changes #14428 (Ericson2314)HttpBinaryCacheStore::uploadmethod #14421 (lovesegfault)CompressedSource#14420 (lovesegfault)completeMultipartUpload()#14391 (lovesegfault)abortMultipartUpload()#14376 (lovesegfault)uploadPart()#14375 (lovesegfault)createMultipartUpload()#14374 (lovesegfault)Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.