Skip to content

激活窗口中查找窗口的部分改成使用Findwindow #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huxinchi wants to merge 3 commits into
base: main
Choose a base branch
from
Open

激活窗口中查找窗口的部分改成使用Findwindow #5

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a3131c5
Update bilibili_mgba_controller.py
huxinchi Aug 30, 2025
307b2b6
Update bilibili_mgba_controller.py
huxinchi Aug 30, 2025
51c3e24
Update bilibili_mgba_controller.py
huxinchi Aug 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions bilibili_mgba_controller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,20 +249,10 @@ def broadcast_danmaku(danmaku_data):

def activate_mgba_window(search_text: str = MGBA_WINDOW_TITLE):
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot Aug 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (code-quality): We've found these issues:


Explanation

The quality score for this function is below the quality threshold of 25%.
This score is a combination of the method length, cognitive complexity and working memory.

How can you solve this?

It might be worth refactoring this function to make it shorter and more readable.

  • Reduce the function length by extracting pieces of functionality out into
    their own functions. This is the most important thing you can do - ideally a
    function should be less than 10 lines.
  • Reduce nesting, perhaps by introducing guard clauses to return early.
  • Ensure that variables are tightly scoped, so that code using related concepts
    sits together within the function rather than being scattered.

"""查找并激活 mGBA 窗口（改进版本）"""
def enum_windows(hwnd, results):
if win32gui.IsWindowVisible(hwnd):
title = win32gui.GetWindowText(hwnd)
if search_text in title:
results.append(hwnd)

hwnd_list = []
win32gui.EnumWindows(enum_windows, hwnd_list)

if not hwnd_list:
hwnd=win32gui.FindWindow(None,search_text)
Comment thread
huxinchi marked this conversation as resolved.
if not hwnd:
logger.error(f"No window found with '{search_text}' in title")
return False

hwnd = hwnd_list[0]
with window_lock: # 线程安全
try:
# 检查窗口是否已经是前台窗口
Expand Down