Fix: allow mixed-case scoped package names#40
Closed
JoeCardoso13 wants to merge 1 commit intomainfrom
Closed
Conversation
GitHub usernames can contain uppercase letters, but SCOPED_REGEX only matched lowercase. Added the /i flag to all name-validation regexes and updated error messages. Includes regression tests for mixed-case acceptance and invalid-character rejection.
Collaborator
Author
|
Closes #39 |
Collaborator
Author
|
Changed to #41 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JoeCardoso13), butSCOPED_REGEXonly matched lowercase — causing the announce endpoint to reject valid names like@JoeCardoso13/openweathermapwith a 400 error./iflag to all name-validation regexes inpackages.ts,bundles.ts, andskills.ts, and updated error messages to remove "lowercase".Test plan
pnpm --filter @nimblebrain/mpak-registry test— all 82 tests pass (80 existing + 2 new)