feat!: support for eddsa signatures #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablojhl
force-pushed
the
feat/eddsa-nada-types
branch
from
245e12e to
17983eb
Compare
pablojhl
force-pushed
the
feat/eddsa-nada-types
branch
from
17983eb to
64cd22e
Compare
pablojhl
requested review from
a team,
andreasbros,
lumasepa,
mfontanini and
tim-hm
and removed request for
a team
mfontanini
approved these changes
Mar 7, 2025
lumasepa
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for eddsa signatures.
The eddsa tests are ignored because there is a bug in nilvm when NadaValue::EddsaPrivateKey is created. It fails when a private key generated by the native library is provided. They will be activated in a follow-up task when this bug is fixed.
Examples will be added in a follow-up as well when the bug is fixed.