-
Notifications
You must be signed in to change notification settings - Fork 43
Feature/nil bridge unit tests #950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
37d14ce to
650c779
Compare
dfcfdca to
7db44bc
Compare
0e0e27a to
7eaa200
Compare
7eaa200 to
9b918a5
Compare
9b918a5 to
8d8f34b
Compare
|
|
||
| function getRemappings() { | ||
| const remappingsTxt = fs.readFileSync("remappings.txt", "utf8"); | ||
| //const remappingsTxt = fs.readFileSync("remappings.txt", "utf8"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
useless comment
8d8f34b to
7653062
Compare
| nil: { | ||
| url: process.env.NIL_RPC_ENDPOINT, | ||
| accounts: process.env.PRIVATE_KEY ? [process.env.PRIVATE_KEY] : [], | ||
| accounts: process.env.NIL_PRIVATE_KEY ? [process.env.NIL_PRIVATE_KEY] : [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does PRIVATE_KEY environment variable used by any another scripts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akokoshn this is used in the function to create a new smart-account
we are in midst of getting rid of this variable and create new key-pair for unit tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will be removed in the new PR coming up soon this week @akokoshn
Short Summary
L2ETHBridgeContractsetupTestFixtureto be used by all the unit tests on L2 Bridge ContractsL2 Unit test execution steps:
ensure Nil Node is up and running on the target server or local machine
run these 3 commands