Konstantin_Ivanov by kostya23azaza · Pull Request #48 · NikolaevArtem/Java_Core_June_2021

kostya23azaza · 2021-07-13T19:49:03Z

No description provided.

…Ivanov # Conflicts: # src/main/java/Main.java

…eature/konstantinIvanov

# Conflicts: # README.md # src/main/java/homework_1/Main.java

…vanov

NikolaevArtem · 2021-09-20T17:07:13Z

src/main/java/homework_3/ImmutableClass.java

+import java.util.LinkedList;
+import java.util.List;
+
+public final class ImmutableClass {


Your class is not immutable. I can pass List and then change it, because when you get/set mutable field, you don't make deep copy, you pass the same object (in constructor and in getNew)

src/main/java/homework_4/custom_annotation/db_annotation/Main.java

NikolaevArtem · 2021-09-20T17:13:38Z

src/test/java/homework_2/RandomCharsTableTest.java

+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+
+public class RandomCharsTableTest extends UnitBase {


Most of your tests are failing. Please check

NikolaevArtem · 2021-09-20T17:15:25Z

src/main/java/homework_4/custom_file_reader/CustomFileReader.java

+
+import static java.nio.charset.StandardCharsets.UTF_8;
+
+public class CustomFileReader {


NikolaevArtem · 2021-09-20T17:16:57Z

src/main/java/homework_5/customRegexMatcher/Main.java

+public class Main {
+
+    public static void main(String[] args) {
+        new CustomRegexMatcher().run();


Opt: you could add some greetings message with input example

NikolaevArtem · 2021-09-20T17:18:16Z

src/main/java/homework_5/powerOfNumber/PowerOfNumber.java

+           int result = power.rec(fir, sec);
+           System.out.println(result);
+       } catch (Exception e) {
+           System.out.println("Only 2 non-negative integers are allowed");


Suggested change

System.out.println("Only 2 non-negative integers are allowed");

System.out.println(e.getCause());

Opt

Because you write this message twice in code

NikolaevArtem · 2021-09-20T17:19:46Z

src/main/java/homework_5/powerOfNumber/PowerOfNumber.java

+        if (secondNumber > 0 ) {
+            return firstNumber * rec(firstNumber, secondNumber-1);
+        }
+        return rec(firstNumber, secondNumber) * secondNumber;


What is the case when this line will be used? You don't test it

NikolaevArtem · 2021-09-20T17:22:33Z

src/main/java/homework_6/Main.java

+        Map<MapProblemsMutableGenerator, String> map = new HashMap<>();
+        MapProblemsMutableGenerator m1 = new MapProblemsMutableGenerator(1, "name");
+        MapProblemsMutableGenerator same = new MapProblemsMutableGenerator(1, "name");
+        MapProblemsMutableGenerator m2 = new MapProblemsMutableGenerator(2, "name2");
+        MapProblemsMutableGenerator m3 = new MapProblemsMutableGenerator(3, "name3");
+        MapProblemsMutableGenerator m4 = new MapProblemsMutableGenerator(4, "name4");
+        map.put(m1, "1");
+        map.put(m2, "2");
+        map.put(m3, "3");
+        map.put(m4, "4");
+        System.out.println(m1.equals(same));
+        System.out.println("Trying to get any value by key");
+        map.get(m1);
+        map.get(m2);
+        map.get(m3);
+        map.get(m4);


You just override key/value pair, there's no mutable key problem.

Also, in upper example, collision does appear, but it is not seen in console (opt)

NikolaevArtem · 2021-09-20T17:24:14Z

src/main/java/homework_7/Main.java

+package homework_7;
+
+public class Main {
+    public static void main(String[] args) {


Code conventions are generally not followed, and Functional interface is created with mistakes (you declare generics, but don't use them)

NikolaevArtem · 2021-09-20T17:25:35Z

src/test/java/homework_4/CustomAnnotationTest.java

+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+public class CustomAnnotationTest extends UnitBase {


You can test it all in one test case (opt)

NikolaevArtem

Good! Although some changes are needed, and the code needs refactoring according to Code Conventions. Solution with db_annotation is great!

NikolaevArtem · 2021-09-23T19:11:45Z

src/main/java/homework_3/Flower.java

+make class final
+A parameterized constructor should initialize all the fields performing a deep copy
+Deep Copy of objects should be performed in the getter methods
+*/public final class Flower {


Doesn't fit the requirement from Homework char

NikolaevArtem · 2021-09-23T19:14:39Z

src/main/java/homework_6/MapProblemsMutableGenerator.java

+
+import java.util.Objects;
+
+public class MapProblemsMutableGenerator {


Where's mutable key problem?

kostya23azaza and others added 15 commits July 5, 2021 19:37

ds

076a20a

ds

6bf9f8e

first_homework

592a770

first_homework

17484b9

Merge remote-tracking branch 'origin/master' into feature/Konstantin_…

fb055d7

…Ivanov # Conflicts: # src/main/java/Main.java

first_homework

e5c1fbf

first_homework

366079a

first_homework

13419a1

second_homework

ad6354c

first_homework_again i have no idea what do i do wrong

3e4884f

Create README.md

cf48abe

Update README.md

7b1def2

Update README.md

9c67241

fixed RandomCharsTable task

cfdb99b

delete Main

5bb35c2

kostya23azaza added the bug Code fix needed label Jul 13, 2021

Merge remote-tracking branch 'origin/Feature/konstantinIvanov' into f…

98700eb

…eature/konstantinIvanov

NikolaevArtem changed the title ~~Feature/konstantin ivanov~~ Konstantin_Ivanov Jul 15, 2021

Merge branch 'master' into feature/konstantinIvanov

29a0bf5

# Conflicts: # README.md # src/main/java/homework_1/Main.java

NikolaevArtem added HW_1 Good to go and removed bug Code fix needed labels Jul 15, 2021

kostya23azaza added readyForReview Sign for Artem to take a look and removed readyForReview Sign for Artem to take a look labels Jul 18, 2021

kostya23azaza and others added 7 commits July 20, 2021 16:30

add start method!

cb875be

add start method!

4ed07ef

Delete PyramidPrinter.java

1276e48

Delete RandomCharsTable.java

b2d1c27

Update README.md

884d144

add start method!

d34e189

Merge remote-tracking branch 'origin/master' into Feature/konstantinI…

ca87723

…vanov

NikolaevArtem added HW_2 and removed readyForStudentReview labels Sep 20, 2021

NikolaevArtem reviewed Sep 20, 2021

View reviewed changes

src/main/java/homework_4/custom_annotation/db_annotation/Main.java Show resolved Hide resolved

NikolaevArtem reviewed Sep 20, 2021

View reviewed changes

NikolaevArtem added the HW_4 label Sep 20, 2021

NikolaevArtem reviewed Sep 20, 2021

View reviewed changes

NikolaevArtem added the HW_5 label Sep 20, 2021

NikolaevArtem reviewed Sep 20, 2021

View reviewed changes

NikolaevArtem suggested changes Sep 20, 2021

View reviewed changes

NikolaevArtem added the bug Code fix needed label Sep 20, 2021

kostya23azaza added 2 commits September 22, 2021 14:50

fix bugs in homework 3 and homework 6

9e131ed

fix bugs in homework 6 and in test for homework 2

a3ed72d

kostya23azaza requested a review from NikolaevArtem September 22, 2021 12:09

kostya23azaza added the readyForReview Sign for Artem to take a look label Sep 22, 2021

add test for seaBattle

3b99362

NikolaevArtem removed the readyForReview Sign for Artem to take a look label Sep 23, 2021

NikolaevArtem reviewed Sep 23, 2021

View reviewed changes

NikolaevArtem added HW_7 and removed bug Code fix needed labels Sep 23, 2021

kostya23azaza added 3 commits September 24, 2021 12:56

fix homework 3

9b54d78

fix homework 6

f0bbc5f

fix homework 7 and junit test in homework 2 PyramidPrinterTest

ee58141

kostya23azaza added the readyForReview Sign for Artem to take a look label Sep 24, 2021


		import static java.nio.charset.StandardCharsets.UTF_8;

		public class CustomFileReader {

	System.out.println("Only 2 non-negative integers are allowed");
	System.out.println(e.getCause());


		import static org.junit.jupiter.api.Assertions.assertEquals;

		public class CustomAnnotationTest extends UnitBase {


		import java.util.Objects;

		public class MapProblemsMutableGenerator {

Conversation

kostya23azaza commented Jul 13, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NikolaevArtem left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

NikolaevArtem left a comment •

edited

Loading