Krylosov_Arkady by KrArkadiy · Pull Request #33 · NikolaevArtem/Java_Core_June_2021

KrArkadiy · 2021-07-09T18:56:05Z

No description provided.

KrArkadiy · 2021-07-15T15:36:28Z

Homework_2 done.

…ture/KrylosovArkady # Conflicts: # src/main/java/homework_2/randomCharsTable/Strategy.java

…ture/KrylosovArkady

pepya4ka · 2021-08-06T18:04:10Z

README.md

 | --- | --- | --- |
-| HW1 | [Console printer](https://github.com/NikolaevArtem/Java_Core_June_2021/tree/master/src/main/java/homework_1) | The app that reads input arguments and prints them, until "error" argument |
+| HW1 | [Console printer](https://github.com/NikolaevArtem/Java_Core_June_2021/tree/feature/KrylosovArkady/src/main/java/homework_1) | The app that reads input arguments and prints them, until "error" argument |
+| HW2.1 | [Traffic Light](https://github.com/NikolaevArtem/Java_Core_June_2021/tree/feature/KrylosovArkady/src/main/java/homework_2/trafficLight) | The app that reads input arguments and output, what traffic light color it would be in inputted time. User has an opportunity to enter time in 2 formats |


check links for hw2

pepya4ka · 2021-08-06T18:07:20Z

src/main/java/homework_1/CommandLineArgs.java

+
+public class CommandLineArgs {
+
+    public static final String ANSI_RED = "\u001B[31m";


fix access modifier

pepya4ka · 2021-08-06T18:08:09Z

src/main/java/homework_1/CommandLineArgs.java

@@ -0,0 +1,20 @@
+package Homework_1;


fix name package

pepya4ka · 2021-08-06T18:18:42Z

src/main/java/homework_2/pyramid_printer/PyramidPrinter.java

+        } catch (NumberFormatException | IOException exception) {
+
+        }
+        return -1;


Suggested change

} catch (NumberFormatException | IOException exception) {

}

return -1;

} catch (NumberFormatException | IOException exception) {

return -1;

}

will it work this way?

pepya4ka · 2021-08-06T18:27:51Z

src/main/java/homework_2/pyramid_printer/PyramidPrinter.java

+        if (negativeInput(input)) {
+            System.out.println(ERROR);
+        } else if (input == 0) {
+            System.out.println();
+        } else {
+            printResult(input);
+        }


Suggested change

if (negativeInput(input)) {

System.out.println(ERROR);

} else if (input == 0) {

System.out.println();

} else {

printResult(input);

}

if (negativeInput(input)) {

System.out.println(ERROR);

} else {

printResult(input);

}

and
private void printResult(int input) {
String output = "";
for (int i = 0; i < input; i++) {
output += "x";
}
System.out.println(output);
}
will it work this way?

pepya4ka · 2021-08-06T20:40:59Z

src/main/java/homework_2/random_chars_table/RandomCharsTable.java

+        int counter = 0;
+        while (counter < result.length()) {
+            if (counter == result.length() - 1) {
+                System.out.print(result.charAt(counter));
+                break;
+            }
+            System.out.print(result.charAt(counter) + ", ");
+            counter++;
+        }


Suggested change

int counter = 0;

while (counter < result.length()) {

if (counter == result.length() - 1) {

System.out.print(result.charAt(counter));

break;

}

System.out.print(result.charAt(counter) + ", ");

counter++;

}

for (int i = 0; i < result.length(); i++) {

if (i == result.length() - 1) {

System.out.print(result.charAt(i));

break;

}

System.out.print(result.charAt(i) + ", ");

}

opt

pepya4ka · 2021-08-06T20:48:51Z

src/main/java/homework_2/traffic_light/TrafficLight.java

+    protected void trafficLightColorDetection(int sec) {
+        if (sec % 60 < 35) {
+            System.out.print(ANSI_GREEN + "Green light" + ANSI_RESET);
+        } else if (sec % 60 >= 35 && sec % 60 < 40 || sec % 60 >= 55) {


Suggested change

} else if (sec % 60 >= 35 && sec % 60 < 40 || sec % 60 >= 55) {

} else if (sec % 60 < 40 || sec % 60 >= 55) {

pepya4ka · 2021-08-06T20:50:19Z

src/main/java/homework_2/traffic_light/TrafficLight.java

+        }
+    }
+
+    protected boolean isNegative(int input) {


extra method

pepya4ka · 2021-08-06T20:50:25Z

src/main/java/homework_2/traffic_light/TrafficLight.java

+        return input < 0;
+    }
+
+    private boolean dayOverCheck(int input) {


extra method

pepya4ka · 2021-08-06T20:53:05Z

src/main/java/homework_2/traffic_light/TrafficLight.java

+        return input <= 86399;
+    }
+
+    private boolean isDigit(String input) {


you can to combine isNegative, dayOverCheck and isDigit how validationInput for example

pepya4ka · 2021-08-06T21:02:49Z

src/main/java/homework_4/custom_file_reader/CustomFileReader.java

+    public void run2(String filename) {
+        isCorrectFilename(filename);
+        try{
+            Files.lines(Path.of(getPath(filename))).map(x->x.replaceAll("[,.]","")).forEach(System.out::println);


Path.of() don't exist in java 8

NikolaevArtem · 2021-09-02T11:37:04Z

src/main/java/homework_2/random_chars_table/RandomCharsTable.java

+    private char[][] array;
+    private String strategy;
+    private String inputData;
+    private String result;
+    private int rows;
+    private int columns;


Opt: these should be either local variables or return values

NikolaevArtem · 2021-09-02T11:37:42Z

src/main/java/homework_2/random_chars_table/RandomCharsTable.java

+        }
+    }
+
+    private void parseData(String s){


Opt: As example, this method should return String array

NikolaevArtem · 2021-09-02T11:38:45Z

src/main/java/homework_2/traffic_light/Main.java

+        TrafficLight trafficLight = new TrafficLight();
+        TrafficLightExtraMod trafficLightExtraMod = new TrafficLightExtraMod();
+        if(args[0].equals("seconds")){
+            trafficLight.run();
+        } else {
+            trafficLightExtraMod.run();
+        }


Opt: instantiate obj just if the requirement matches

NikolaevArtem · 2021-09-02T11:39:37Z

Good job with HW_2!

NikolaevArtem · 2021-09-23T09:01:46Z

src/main/java/course_project/Main.java

+
+public class Main {
+    public static void main(String[] args) {
+        Runner runner = new Runner();


Seems broken:

Also, please introduce automatic ship placement

Also, if input is wrong, the app just shuts down. Really annoying in case you make a typo right before the end :)

Have you played your own game?)
Sorry, can't approve a this state

NikolaevArtem · 2021-09-23T17:15:58Z

src/main/java/homework_3/ImmutableClass.java

+No setters.
+ */
+
+final class ImmutableClass {


Your class is mutable 100%

KrArkadiy added 3 commits July 9, 2021 21:51

gitignore updated

b0e8b31

gitignore updated

ecddcf0

Delete Main.java

1df4806

KrArkadiy added the readyForReview Sign for Artem to take a look label Jul 9, 2021

NikolaevArtem added HW_1 Good to go and removed readyForReview Sign for Artem to take a look labels Jul 11, 2021

NikolaevArtem changed the title ~~feature/KrylosovArkady~~ Krylosov_Arkady Jul 11, 2021

KrArkadiy added 7 commits July 15, 2021 17:00

homework_2 done.

8a07313

homework_2 done.

528cd6f

homework_2 done.

e3775d8

homework_2 done.

0e704da

homework_2 done.

5aa7e96

README updated

4d575f2

Update Strategy.java

d41b249

KrArkadiy added the readyForReview Sign for Artem to take a look label Jul 15, 2021

NikolaevArtem removed the readyForReview Sign for Artem to take a look label Jul 20, 2021

ArtemNikolaev1 and others added 13 commits July 22, 2021 00:36

Add UnitBase.java

e2a0229

homework_2 corrected

ede0736

homework_2 corrected

579a708

homework_2 corrected

385c677

Merge remote-tracking branch 'origin/feature/KrylosovArkady' into fea…

14677e0

…ture/KrylosovArkady # Conflicts: # src/main/java/homework_2/randomCharsTable/Strategy.java

Delete Strategy.java

7f07dad

README updated

1a6933d

Update README.md

4f3efcd

Update README.md

835d06c

Merge remote-tracking branch 'origin/feature/KrylosovArkady' into fea…

a186e54

…ture/KrylosovArkady

README updated

42abc65

package naming corrected

a9b9d09

Update README.md

4019fa6

KrArkadiy added the readyForReview Sign for Artem to take a look label Jul 26, 2021

KrArkadiy added 5 commits August 5, 2021 22:36

homework_3 correction

fb46f53

homework_4 realization

478cf57

homework_4 realization

239bf04

homework_4 tests realization

55c43a8

README updated

ab773e1

KrArkadiy added the readyForStudentReview label Aug 5, 2021

pepya4ka reviewed Aug 6, 2021

View reviewed changes

homework_2,4 fixed.

7f594b2

NikolaevArtem reviewed Sep 2, 2021

View reviewed changes

NikolaevArtem added HW_2 and removed bug Code fix needed labels Sep 2, 2021

KrArkadiy added 3 commits September 8, 2021 01:03

homework 5 done.

2cf9724

homework 6 done.

ab37ecc

homework 7 and course project done.

18ae0d6

NikolaevArtem reviewed Sep 23, 2021

View reviewed changes

NikolaevArtem added bug Code fix needed and removed readyForReview Sign for Artem to take a look readyForStudentReview labels Sep 23, 2021

KrArkadiy added 2 commits September 23, 2021 15:21

course project fixed

2bd2afd

course project fixed

fe79848

NikolaevArtem reviewed Sep 23, 2021

View reviewed changes

src/main/java/homework_3/ImmutableClass.java

No setters.

*/

final class ImmutableClass {

Copy link

Owner

NikolaevArtem Sep 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your class is mutable 100%

NikolaevArtem added HW_5 HW_6 HW_7 and removed bug Code fix needed labels Sep 23, 2021


		public class CommandLineArgs {

		public static final String ANSI_RED = "\u001B[31m";

	} else if (sec % 60 >= 35 && sec % 60 < 40 \|\| sec % 60 >= 55) {
	} else if (sec % 60 < 40 \|\| sec % 60 >= 55) {

Conversation

KrArkadiy commented Jul 9, 2021

Uh oh!

KrArkadiy commented Jul 15, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NikolaevArtem commented Sep 2, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants