Anton_Segodnik by AntonSegodnik · Pull Request #28 · NikolaevArtem/Java_Core_June_2021

AntonSegodnik · 2021-07-09T11:56:47Z

Homework_1

# Conflicts: # src/main/java/homework_1/Main.java

…anged

build.gradle

filipchikkirill · 2021-09-07T13:40:44Z

src/main/java/homework_2/random_chars_table/ParserInputData.java

+            int row = Integer.parseInt(arrayWithInputData[0]);
+            int column = Integer.parseInt(arrayWithInputData[1]);
+
+            String typeOfParity = arrayWithInputData[2];


where do you check that you have arrayWithInputData.length >= 3 ?
ArrayIndexOutOfBoundsException

filipchikkirill · 2021-09-07T13:47:59Z

src/main/java/homework_2/traffic_light/TrafficLight.java

+            System.out.println(ANSI_STRIKEOUT_YELLOW + "Yellow" + ANSI_RESET);
+        } else {
+            System.out.println(ANSI_STRIKEOUT_RED + "Red" + ANSI_RESET);
+        }


Does not match the condition of the task

private void checkColor(int time) { if(time < 0 || time >= 86400) return; int sec = time % 60; if(sec < 35) { System.out.println(ANSI_STRIKEOUT_GREEN + "Green" + ANSI_RESET); } else if(sec < 40 || sec >= 55) { System.out.println(ANSI_STRIKEOUT_YELLOW + "Yellow" + ANSI_RESET); } else { System.out.println(ANSI_STRIKEOUT_RED + "Red" + ANSI_RESET); }

Does not match the condition of the task

private void checkColor(int time) { if(time < 0 || time >= 86400) return; int sec = time % 60; if(sec < 35) { System.out.println(ANSI_STRIKEOUT_GREEN + "Green" + ANSI_RESET); } else if(sec < 40 || sec >= 55) { System.out.println(ANSI_STRIKEOUT_YELLOW + "Yellow" + ANSI_RESET); } else { System.out.println(ANSI_STRIKEOUT_RED + "Red" + ANSI_RESET); }

What's wrong?

my bad. sry. your way of writing is confusing.
if(time < 0 || time >= 86400) return;

but all ok.

NikolaevArtem · 2021-09-22T07:52:17Z

README.md

+|HW4 | [singleton](https://github.com/NikolaevArtem/Java_Core_June_2021/tree/feature/AntonSegodnik/src/main/java/homework_4/singleton) | The singleton app  |
+|HW5 | [customRegexMatcher](https://github.com/NikolaevArtem/Java_Core_June_2021/tree/feature/AntonSegodnik/src/main/java/homework_5/customRegexMatcher) | The  app  |
+|HW5 | [PowerOfNumber](https://github.com/NikolaevArtem/Java_Core_June_2021/tree/feature/AntonSegodnik/src/main/java/homework_5/PowerOfNumber) | The  app  |
+|HW6 | [MapProblemsCollisionGenerator](https://github.com/NikolaevArtem/Java_Core_June_2021/tree/feature/AntonSegodnik/src/main/java/homework_6/MapProblemsCollisionGenerator) | The  app  |
+|HW6 | [MapProblemsMutableGenerator](https://github.com/NikolaevArtem/Java_Core_June_2021/tree/feature/AntonSegodnik/src/main/java/homework_6/MapProblemsMutableGenerator) | The  app  |
+|HW7 | [KittenToCatFunction](https://github.com/NikolaevArtem/Java_Core_June_2021/tree/feature/AntonSegodnik/src/main/java/homework_7) | The  app  |


Nice description...

NikolaevArtem · 2021-09-22T07:58:45Z

src/main/java/SeaBattle/Main.java

+
+    public static void main(String[] args) {
+
+        StartGame startGame = new StartGame();


Looks like a fresh view on the course project, fits the requirement, but doesn't look good, not from the interface and not from the code. You show knowledge in Java Core, I don't see much architecture or right abstractions in the app. Playing is nice though, but x for miss and X for hit looks awful...

Approved!

NikolaevArtem · 2021-09-22T08:04:54Z

src/main/java/homework_3/ImmutableClass.java

+// Deep Copy of objects should be performed in the getter methods (To return a copy rather than returning the actual object reference)
+// No setters (To not have the option to change the value of the instance variable)
+
+public final class ImmutableClass {


One field should be mutable

NikolaevArtem · 2021-09-22T08:05:50Z

src/main/java/homework_4/customFileReader/Main.java

+public class Main {
+
+    public static void main(String[] args) {
+        String path = "src/main/resources/custom_file_reader.txts";


NikolaevArtem · 2021-09-22T08:07:33Z

src/main/java/homework_5/powerOfNumber/Main.java

+//        System.out.println (powerOfNumber.recursion (2, 2));
+//        System.out.println (powerOfNumber.recursion (2, 1));
+//        System.out.println (powerOfNumber.recursion (2, 0));
+//        System.out.println (powerOfNumber.recursion (0, 2));
+//        System.out.println (Math.pow(2,2));
+//        System.out.println (Math.pow(2,1));
+//        System.out.println (Math.pow(2,0));
+//        System.out.println (Math.pow(0,2));


What's this?

NikolaevArtem · 2021-09-22T08:11:17Z

src/main/java/homework_6/Main.java

+
+import java.util.HashMap;
+
+public class Main {


NikolaevArtem

Hm... you did the homework (except minor fixes in HW_3), but mostly it just fits the requirements in the easiest way possible. It seems you didn't really like working with code

Ping me when you fix HW_3

NikolaevArtem · 2021-09-23T19:36:32Z

src/main/java/homework_3/ImmutableClass.java

    private ImmutableClass createNewObj() {
        return new ImmutableClass();
    }


There's no purpose for this method. Doesn't fit the criteria

Yep, should i just make this method as public or this method must accept any values ? (Made as public)

Anton.Segodnik added 6 commits July 5, 2021 19:40

AS commit

bba4c50

AS commit git ignore

39cd05f

05.07 Home Work 1

26433ce

06.07.21 Home Work 1.1 with Red Color

c21fa4e

AS commit

12b4c21

05.07 Home Work 1

5c04832

AntonSegodnik force-pushed the feature/AntonSegodnik branch from c21fa4e to 5c04832 Compare July 9, 2021 20:11

Anton.Segodnik added 2 commits July 9, 2021 23:14

homework_1

95720c0

Merge branch 'master' into feature/AntonSegodnik

83dd7ba

# Conflicts: # src/main/java/homework_1/Main.java

AntonSegodnik requested a review from NikolaevArtem July 9, 2021 20:22

AntonSegodnik added the readyForReview Sign for Artem to take a look label Jul 9, 2021

Anton.Segodnik added 2 commits July 11, 2021 12:51

homework_1 with red "Alarm" + read.me: added link to main

ed9c6b0

homework_1 with red "Alarm" + read.me: added link to main and Name ch…

4df4686

…anged

NikolaevArtem added HW_1 Good to go and removed readyForReview Sign for Artem to take a look labels Jul 11, 2021

NikolaevArtem changed the title ~~Feature/anton segodnik~~ Anton_Segodnik Jul 11, 2021

Anton.Segodnik added 3 commits July 14, 2021 21:32

homework_2 with BufferReaders methods

0788e6c

homework_2 with BufferReaders methods + Read me

df79a67

homework_2 with BufferReaders methods + Read me again

3968d87

AntonSegodnik added the readyForReview Sign for Artem to take a look label Jul 14, 2021

AntonSegodnik assigned NikolaevArtem Jul 14, 2021

NikolaevArtem removed the readyForReview Sign for Artem to take a look label Jul 20, 2021

Anton.Segodnik added 6 commits July 21, 2021 17:53

homework_2 with hierarchy and run()

85299bd

homework_2 with hierarchy and run() + read.me

6a71478

homework_3

2ce4e3e

Merge branch 'master' into feature/AntonSegodnik

07dfad9

homework_3 + tests

2e7c00c

homework_3 + tests finish version

b4a2b84

AntonSegodnik added the readyForReview Sign for Artem to take a look label Jul 25, 2021

NikolaevArtem reviewed Jul 25, 2021

View reviewed changes

build.gradle Outdated Show resolved Hide resolved

homework_6 finished

97eca5e

AntonSegodnik added the readyForReview Sign for Artem to take a look label Sep 6, 2021

homework_6 finished + read me

90a99eb

filipchikkirill reviewed Sep 7, 2021

View reviewed changes

Fix 2 from Kirill

de1a0bd

AntonSegodnik added the readyForStudentReview label Sep 7, 2021

Anton Segodnik added 3 commits September 19, 2021 22:17

Final project w/o tests

c11b05a

Final project with some tests

04aa763

Homework_7 added

ac78bf6

NikolaevArtem removed bug Code fix needed readyForReview Sign for Artem to take a look readyForStudentReview labels Sep 22, 2021

NikolaevArtem reviewed Sep 22, 2021

View reviewed changes

NikolaevArtem added Course Project HW_2 labels Sep 22, 2021

NikolaevArtem reviewed Sep 22, 2021

View reviewed changes

NikolaevArtem added HW_4 HW_5 labels Sep 22, 2021

NikolaevArtem reviewed Sep 22, 2021

View reviewed changes

src/main/java/homework_6/Main.java

import java.util.HashMap;

public class Main {

Copy link

Owner

NikolaevArtem Sep 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

NikolaevArtem added HW_6 HW_7 labels Sep 22, 2021

NikolaevArtem suggested changes Sep 22, 2021

View reviewed changes

Anton Segodnik added 2 commits September 22, 2021 12:22

Fix hm 3, and "txts"

a43f2d5

Fix hm 3, and "txts"

75f3deb

NikolaevArtem reviewed Sep 23, 2021

View reviewed changes

fix 3 just public

4ee8e31


		public static void main(String[] args) {

		StartGame startGame = new StartGame();

Conversation

AntonSegodnik commented Jul 9, 2021

Uh oh!

Uh oh!

filipchikkirill Sep 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NikolaevArtem Sep 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NikolaevArtem left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AntonSegodnik Sep 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

filipchikkirill Sep 7, 2021 •

edited

Loading

NikolaevArtem Sep 22, 2021 •

edited

Loading

AntonSegodnik Sep 23, 2021 •

edited

Loading