Semen_Antufiev by antufievsemen · Pull Request #23 · NikolaevArtem/Java_Core_June_2021

antufievsemen · 2021-07-08T18:46:01Z

No description provided.

Rework print to console.

src/main/java/homework_1/Main.java

src/main/java/homework_3/pyramidprinter/Main.java

src/main/java/homework_3/pyramidprinter/PyramidPrinter.java

README.md

pepya4ka · 2021-08-05T01:20:51Z

src/main/java/homework_1/Main.java

+        break;
+      }

+      System.out.println(arg + " : " + arg.length() + " letters");


Suggested change

System.out.println(arg + " : " + arg.length() + " letters");

System.out.println(arg + ": " + arg.length() + " letters");

pepya4ka · 2021-08-05T01:22:15Z

src/main/java/homework_2/pyramid_printer/PyramidPrinter.java

+        Scanner scanner = new Scanner(System.in);
+        String sizeAsString = scanner.nextLine();
+        if (!isNumber(sizeAsString)) {
+            System.out.println("ERROR! This is not a number");


check the output format in the task

pepya4ka · 2021-08-05T01:23:35Z

src/main/java/homework_2/random_chars_table/RandomCharsTable.java

+        for (int i = 0; i < params.length; i++) {
+            params[i] = scanner.next();
+        }
+        if (!isNumber(params[0]) || !isNumber(params[1])) {


move validate to a new separate method (validateParams, for example)

pepya4ka · 2021-08-05T01:23:49Z

src/main/java/homework_2/random_chars_table/RandomCharsTable.java

+            params[i] = scanner.next();
+        }
+        if (!isNumber(params[0]) || !isNumber(params[1])) {
+            System.out.println("ERROR! This is not a number");


check the output format in the task

pepya4ka · 2021-08-05T01:26:15Z

src/main/java/homework_2/random_chars_table/RandomCharsTable.java

+        }
+        String strategy = params[2];
+        int strategyMod;
+        if (strategy.equals("even")) {


move to a new separate method (getResult, for example)

Because your code is too complex and difficult to read

pepya4ka · 2021-08-05T01:27:06Z

src/main/java/homework_2/traffic_light/TrafficLight.java

+        Scanner scanner = new Scanner(System.in);
+        String secondsAsString = scanner.next();
+        if (isNumber(secondsAsString)) {
+            System.out.println("ERROR! Seconds must be a number");


check the output format in the task

pepya4ka · 2021-08-05T01:28:32Z

src/main/java/homework_3/ImmutableClass.java

+
+    private final int age;
+
+    private final int high;


add new mutable class field

I thought it's a requirement

NikolaevArtem · 2021-09-02T11:08:33Z

src/main/java/homework_2/pyramid_printer/PyramidPrinter.java

+        int size = Integer.parseInt(sizeAsString);
+        for (int i = 0; i < size; i++) {
+            for (int j = 0; j <= i; j++) {
+                System.out.print("*");


I thought we're printing x...

NikolaevArtem · 2021-09-02T11:09:05Z

src/main/java/homework_2/pyramid_printer/PyramidPrinter.java

+import java.util.Scanner;
+import java.util.regex.Pattern;
+
+public class PyramidPrinter {


NikolaevArtem · 2021-09-02T11:09:53Z

src/main/java/homework_2/pyramid_printer/PyramidPrinter.java

+        if (isNumber(sizeAsString)) {
+            System.out.println(ERROR_MESSAGE);
+            return;
+        }


If number, then error?

NikolaevArtem · 2021-09-02T11:11:36Z

src/main/java/homework_2/random_chars_table/RandomCharsTable.java

+import java.util.Scanner;
+import java.util.regex.Pattern;
+
+public class RandomCharsTable {


NikolaevArtem · 2021-09-02T11:13:35Z

src/main/java/homework_2/random_chars_table/RandomCharsTable.java

+        for (int i = 0; i < params.length; i++) {
+            params[i] = scanner.next();
+        }
+        if (isNumber(params[0]) || isNumber(params[1])) {


Quite strange

NikolaevArtem · 2021-09-02T11:14:04Z

src/main/java/homework_2/random_chars_table/RandomCharsTable.java

+        if (rows == 0 || columns == 0) {
+            return;
+        }


It's not expected behaviour, according to chat

NikolaevArtem · 2021-09-02T11:15:48Z

src/main/java/homework_2/traffic_light/TrafficLight.java

+    public static final String ERROR_MESSAGE = "Only 1 non-negative integer is allowed as passed parameter";
+    public static final String DAY_OVER = "The day is over";
+
+    public void run() {


Here and in other places: i would recommend getting rid of multiple if/else statements and separate logic to other methods

antufievsemen added 3 commits July 7, 2021 20:16

Homework 1 is done

ed90031

Homework 1 is done.

ffc5bc7

Rework print to console.

Made README.md correct style.

5fc4b66

ArtemNikolaev1 reviewed Jul 9, 2021

View reviewed changes

src/main/java/homework_1/Main.java Outdated Show resolved Hide resolved

NikolaevArtem added wontfix bug Code fix needed and removed wontfix labels Jul 9, 2021

Deleted if condition

f48b06e

NikolaevArtem changed the title ~~Feature/SemenAntufiev~~ Semen_Antufiev Jul 11, 2021

antufievsemen added the readyForReview Sign for Artem to take a look label Jul 12, 2021

NikolaevArtem reviewed Jul 13, 2021

View reviewed changes

src/main/java/homework_1/Main.java Outdated Show resolved Hide resolved

NikolaevArtem added HW_1 Good to go style Style fix needed and removed bug Code fix needed readyForReview Sign for Artem to take a look labels Jul 13, 2021

Fixed style

9d17d84

antufievsemen added the readyForReview Sign for Artem to take a look label Jul 13, 2021

antufievsemen added 3 commits July 20, 2021 01:16

Completed the homework3

d8ea763

Rename package with homework 3

431d201

Added new homework and codingbat to README.md and fix style

3452255

NikolaevArtem removed the readyForReview Sign for Artem to take a look label Jul 20, 2021

NikolaevArtem reviewed Jul 25, 2021

View reviewed changes

src/main/java/homework_3/pyramidprinter/Main.java Outdated Show resolved Hide resolved

NikolaevArtem reviewed Jul 25, 2021

View reviewed changes

src/main/java/homework_3/pyramidprinter/PyramidPrinter.java Outdated Show resolved Hide resolved

NikolaevArtem added bug Code fix needed and removed style Style fix needed labels Jul 25, 2021

antufievsemen added 5 commits July 25, 2021 23:16

Rename package and init method to homework on run()

8cc135a

Rename packages

de07ae6

Complete the homework 3

963ac04

Add homework 3 to README

65f4556

Fix README urls for homework 2

0ca6164

Add scanner to homework 2

770b5c8

antufievsemen added readyForReview Sign for Artem to take a look readyForStudentReview labels Jul 30, 2021

pepya4ka reviewed Aug 5, 2021

View reviewed changes

antufievsemen added 6 commits August 5, 2021 19:33

Rework README.md and fix output message for incorrect params

7a446d2

Complete homework 4

c7a5739

Add homework 4 to README.md

560a704

Add tests for homeworks

6cc3fbe

Rework test to custom file reader

2c248d5

Complete homework_5

70a947f

NikolaevArtem reviewed Sep 2, 2021

View reviewed changes

NikolaevArtem removed readyForReview Sign for Artem to take a look readyForStudentReview labels Sep 2, 2021

	System.out.println(arg + " : " + arg.length() + " letters");
	System.out.println(arg + ": " + arg.length() + " letters");

Conversation

antufievsemen commented Jul 8, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NikolaevArtem Sep 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

NikolaevArtem Sep 2, 2021 •

edited

Loading