Regina_Gabdrakhimova by GabdrakhimovaRR · Pull Request #21 · NikolaevArtem/Java_Core_June_2021

GabdrakhimovaRR · 2021-07-08T13:25:31Z

Completed homework_1

src/main/java/homework_1/Main.java

…o feature/ReginaGabdrakhimova

src/main/java/homework_1/Main.java

NikolaevArtem · 2021-09-02T11:05:00Z

Seems forgotten

src/main/java/homework_2/pyramid_printer/PyramidPrinter.java

src/main/java/homework_2/traffic_light/TrafficLight.java

src/main/java/homework_2/random_chars_table/RandomCharsTable.java

src/main/java/homework_2/pyramid_printer/PyramidPrinter.java

NikolaevArtem · 2021-09-22T08:48:19Z

src/main/java/course_project/Main.java

@@ -0,0 +1,7 @@
+package course_project;
+
+public class Main {


Quite a strange ship here

Good job! The game is playable and has a nice description, the code is pretty readable. It seems there are some bugs, good that you have automatic ship placement, the interface is cool. You show knowledge of Java Core and Java libraries. Abstractions and architecture is TBD

To make it better: add some features (like automatically mark cells around destroyed ship as miss), introduce the architecture, and more abstractions.

Ping me when you resolved this bug and tested your app manually for other bugs (like, what happens if the computer hits a cell already marked as a miss?)

The game shows me the opponent's field in the beginning? Have you played your game yourself?)

Opt: Also, there are no messages what happened - did computer (or me) hit or miss, how many times computer shot and etc...

NikolaevArtem · 2021-09-22T08:57:13Z

src/main/java/homework_3/immutable_class/MyImmutableBag.java

+    public MyImmutableBag changeCash(int newCash) {
+        return new MyImmutableBag(newCash, documents, pills);
+    }
+
+    public MyImmutableBag changeDocuments(ArrayList<String> newDocuments) {
+        return new MyImmutableBag(cash, newDocuments, pills);
+    }
+
+    public MyImmutableBag changePills(Map<String, String> newPills) {
+        return new MyImmutableBag(cash, documents, newPills);
+    }
+}


Here you don't make a copy of mutable objects, thus your class is mutable

NikolaevArtem · 2021-09-22T08:59:17Z

src/main/java/homework_5/custom_regex_matcher/CustomRegexMatcher.java

+
+public class CustomRegexMatcher {
+
+    public void run() {


Nice example with different messages!

NikolaevArtem · 2021-09-22T09:02:59Z

src/main/java/homework_6/map_problems_generator/MapProblemsMutableGenerator.java

+    public int hashCode() {
+        return new Random().nextInt(121);
+    }


I know it's unclear from the homework description, but here is not a mutable key problem, it's just invalid hashcode impl. Mutable key problem appears when hashcode generation is valid

NikolaevArtem · 2021-09-22T09:03:52Z

src/main/java/homework_7/Main.java

@@ -0,0 +1,24 @@
+package homework_7;
+
+public class Main {


Nice, great example with type conversion!

Are there any issues in homework 7? Label has not been tagged

No issues, added

NikolaevArtem

Good job! The code is readable, covered by tests, I see you experimented with most of what we've learned in lectures. There are some minor issues to fix and a bug in Cource project TBD

GabdrakhimovaRR and others added 3 commits July 7, 2021 15:54

111

d4cf36e

Completed homework_1

0418c02

Update README.md

a510721

ArtemNikolaev1 reviewed Jul 9, 2021

View reviewed changes

src/main/java/homework_1/Main.java Outdated Show resolved Hide resolved

NikolaevArtem added wontfix bug Code fix needed and removed wontfix labels Jul 9, 2021

GabdrakhimovaRR added 2 commits July 10, 2021 01:44

homework_1(2)

468f48e

Merge remote-tracking branch 'origin/feature/ReginaGabdrakhimova' int…

3f41d39

…o feature/ReginaGabdrakhimova

GabdrakhimovaRR added the readyForReview Sign for Artem to take a look label Jul 10, 2021

NikolaevArtem reviewed Jul 11, 2021

View reviewed changes

src/main/java/homework_1/Main.java Outdated Show resolved Hide resolved

NikolaevArtem added HW_1 Good to go style Style fix needed and removed bug Code fix needed readyForReview Sign for Artem to take a look labels Jul 11, 2021

NikolaevArtem changed the title ~~feature/ReginaGabdrakhimova~~ Regina_Gabdrakhimova Jul 11, 2021

GabdrakhimovaRR added 2 commits July 26, 2021 07:58

homework_1(fixed indentation)

ca5976b

homework_2

766336a

GabdrakhimovaRR removed the style Style fix needed label Jul 26, 2021

Update README.md

76b4e64

GabdrakhimovaRR added the readyForReview Sign for Artem to take a look label Jul 26, 2021

GabdrakhimovaRR removed the readyForReview Sign for Artem to take a look label Aug 23, 2021

Merge branch 'master' into feature/ReginaGabdrakhimova

01931b1

NikolaevArtem closed this Sep 2, 2021

NikolaevArtem reopened this Sep 2, 2021

NikolaevArtem reviewed Sep 2, 2021

View reviewed changes

src/main/java/homework_2/pyramid_printer/PyramidPrinter.java Outdated Show resolved Hide resolved

NikolaevArtem reviewed Sep 2, 2021

View reviewed changes

src/main/java/homework_2/traffic_light/TrafficLight.java Show resolved Hide resolved

NikolaevArtem reviewed Sep 2, 2021

View reviewed changes

src/main/java/homework_2/random_chars_table/RandomCharsTable.java Show resolved Hide resolved

NikolaevArtem reviewed Sep 2, 2021

View reviewed changes

src/main/java/homework_2/pyramid_printer/PyramidPrinter.java Outdated Show resolved Hide resolved

GabdrakhimovaRR added 9 commits September 10, 2021 02:52

Update README.md

68a1def

homework_4. CustomFileReader

ed66aa6

homework_4. CustomAnnotation

5430f07

homework_5. PowerOfNumber

61294c2

homework_6. MapProblemsGenerator

73c93ca

homework_3,4,5 Tests

33cf811

Test of homework_4.CustomFileReader

8c3063d

Course Project "Sea Battle"

232e3f7

homework_7. KittenToCatFunction

75d466e

NikolaevArtem removed the readyForReview Sign for Artem to take a look label Sep 22, 2021

NikolaevArtem reviewed Sep 22, 2021

View reviewed changes

NikolaevArtem added HW_2 HW_4 labels Sep 22, 2021

NikolaevArtem reviewed Sep 22, 2021

View reviewed changes

NikolaevArtem added the HW_5 label Sep 22, 2021

NikolaevArtem reviewed Sep 22, 2021

View reviewed changes

NikolaevArtem suggested changes Sep 22, 2021

View reviewed changes

NikolaevArtem added the bug Code fix needed label Sep 22, 2021

Fixed bugs in homework 3, 6 and course project.

314ceff

GabdrakhimovaRR added readyForReview Sign for Artem to take a look and removed bug Code fix needed labels Sep 23, 2021

NikolaevArtem added HW_3 HW_6 HW_7 labels Sep 23, 2021

GabdrakhimovaRR added 2 commits September 23, 2021 16:02

Fixed bug in course project.

395aa28

Fixed bug in course project(2).

1d70974

NikolaevArtem added Course Project and removed readyForReview Sign for Artem to take a look labels Sep 23, 2021

Conversation

GabdrakhimovaRR commented Jul 8, 2021

Uh oh!

Uh oh!

Uh oh!

NikolaevArtem commented Sep 2, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NikolaevArtem left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants