Chertov_Nikita by Sotheres · Pull Request #18 · NikolaevArtem/Java_Core_June_2021

Sotheres · 2021-07-08T09:13:14Z

No description provided.

# Conflicts: # .gitignore # src/main/java/Main.java

# Conflicts: # src/main/java/homework_1/Main.java

PyramidPrinter update RandomCharsTable update

ijustwannatry · 2021-07-15T09:04:02Z

src/main/java/homework_2/TrafficLight.java

+                String line = scan.next();
+                String[] input = line.split(":");
+                int hh = Integer.parseInt(input[0]);
+                int mm = Integer.parseInt(input[1]);
+                int ss = Integer.parseInt(input[2]);
+                validateInputMode2(hh, mm, ss, input.length);
+                seconds = ss + mm * 60 + hh * 3600;


You can make it much shorter, literally in a line. Check Class java.time.LocalTime. Have a look at parse() and toSecondOfDay() methods. It's better to use a ready-made bicycle than to reinvent it :)

Thanks!)
Didn't know about that class' functionality.

You can make it much shorter, literally in a line. Check Class java.time.LocalTime. Have a look at parse() and toSecondOfDay() methods. It's better to use a ready-made bicycle than to reinvent it :)

NikolaevArtem · 2021-07-25T18:18:57Z

src/main/java/homework_2/random_chars_table/TablePrinter.java

+    public void printTable() {
+        charList = new LinkedList<>();
+        for (int i = 0; i < rows; i++) {
+            System.out.print("| ");


Please remove whitespace, it fail my tests. In AC the output is without whitespaces

NikolaevArtem · 2021-07-25T18:20:32Z

Good, the apps run as expected. I'll continue review when I'll have time

…ure/ChertovNikita

HW4 CFR removePunctuation update

HW5 test folder refactoring

ArtemNikolaev1 · 2021-09-20T13:06:52Z

src/main/java/course_project/Main.java

+public class Main {
+
+    public static void main(String[] args) {
+        new SeaBattle().playVsComputer();


Good use of abstractions, thorough knowledge of Java Core aspects and libraries. Well done!

To make better: Quite difficult to play, during ship placement the field does not show my placed ships. Also, you could Introduce random ship placement. And void methods are not thread-safe and easy to test, better use return values

ArtemNikolaev1 · 2021-09-20T13:10:11Z

src/main/java/course_project/SeaBattle.java

+        placePlayersShips();
+        placeComputerShips();
+        makeMoves();
+        defineWinner();
+        closeInput();


Opt: these methods should have return values. It helps to test them separately. Better not to use void methods.

Opt: ship placement is difficult to understand (h1 hor on empty field does not work)

ArtemNikolaev1 · 2021-09-20T13:10:49Z

src/main/java/course_project/SeaBattle.java

+    void placePlayersShips() {
+        new UserShipPlacer(scanner).placeShips(playersField);
+    }


Opt: It does not make sense to put oneliner into a separate method

ArtemNikolaev1 · 2021-09-20T13:16:57Z

src/main/java/course_project/components/Coordinate.java

+        int result = Integer.hashCode(x);
+        result = 31 * result + Integer.hashCode(y);
+        return result;


Suggested change

int result = Integer.hashCode(x);

result = 31 * result + Integer.hashCode(y);

return result;

return 31 * Integer.hashCode(x)+ Integer.hashCode(y);;

NikolaevArtem · 2021-09-20T13:35:25Z

src/main/java/homework_3/Cafe.java

+ * Immutable class is extremely well encapsulated!
+ */
+
+public final class Cafe {


NikolaevArtem · 2021-09-20T13:38:54Z

src/main/java/homework_4/custom_file_reader/CustomFileReader.java

+import java.util.Scanner;
+import java.util.stream.Stream;
+
+public class CustomFileReader {


Many possible ways, good job!

NikolaevArtem · 2021-09-20T13:43:17Z

src/main/java/homework_5/power_of_number/PowerOfNumber.java

+        if (!tail.equals("")) {
+            throw new IllegalArgumentException();


I don't understand the usage for this line

Just an odd way to check if there is more then just two numbers...
Should simply use regex to validate input.

NikolaevArtem · 2021-09-20T13:49:49Z

src/main/java/homework_7/KittenToCatFunction.java

+import homework_7.util.Kitten;
+
+@FunctionalInterface
+public interface KittenToCatFunction <R extends Cat, T extends Kitten> {


Good, looks nice!

NikolaevArtem · 2021-09-20T13:50:28Z

src/test/java/homework_2_test/pyramid_printer/PyramidPrinterTest.java

+    private final String errorMsg = "Only 1 non-negative integer is allowed as passed parameter";
+
+    @Test
+    void givenThree_whenRun_thenPrintPyramid() {


Special thanks for informative test cases names, it really helps

NikolaevArtem

Minor issues/code style fixes.
Except that, homework is accepted!

Sotheres added 7 commits July 5, 2021 19:20

aaaa

08cee92

v1

35505cc

Homework 1

212b306

Merge remote-tracking branch 'origin/master' into Feature/NikitaChertov

0417ac5

# Conflicts: # .gitignore # src/main/java/Main.java

Merge remote-tracking branch 'origin/master' into feature/ChertovNikita

d4423dc

# Conflicts: # src/main/java/homework_1/Main.java

Homework 1

bc145db

Homework 1

43ca781

ArtemNikolaev1 approved these changes Jul 9, 2021

View reviewed changes

NikolaevArtem approved these changes Jul 9, 2021

View reviewed changes

NikolaevArtem added the HW_1 Good to go label Jul 9, 2021

NikolaevArtem modified the milestone: homework_1 is done Jul 9, 2021

NikolaevArtem changed the title ~~Feature/chertov nikita~~ Chertov_Nikita Jul 11, 2021

Sotheres added 4 commits July 13, 2021 14:39

PyramidPrinter

a4d8a15

RandomCharsTable

e1022da

TrafficLight

7cf7d50

PyramidPrinter update RandomCharsTable update

update

5c5c468

Sotheres added the readyForReview Sign for Artem to take a look label Jul 14, 2021

ijustwannatry reviewed Jul 15, 2021

View reviewed changes

LocalTime version

e41d953

NikolaevArtem removed the readyForReview Sign for Artem to take a look label Jul 20, 2021

Sotheres added 3 commits July 23, 2021 16:40

HW2 refactoring update

6f2619b

Merge remote-tracking branch 'origin/master' into feature/ChertovNikita

1050bb6

HW2 unit test coverage

f0faba8

NikolaevArtem reviewed Jul 25, 2021

View reviewed changes

NikolaevArtem added the HW_2 label Jul 25, 2021

Readme update

7bcda0b

Sotheres added 13 commits August 16, 2021 14:24

Delete defaultInput.txt

f5c1ae7

HW4 CustomFileReader update

e2771a5

Merge remote-tracking branch 'origin/Feature/ChertovNikita' into Feat…

e4e129a

…ure/ChertovNikita

HW5 PowerOfNumber added

3d2a834

HW5 PowerOfNumber update

f117f48

HW5 CustomRegexMatcher added

b007ce9

HW6 added.

beb9349

HW4 CFR removePunctuation update

Readme update.

66684a2

HW5 test folder refactoring

HW7 added

62d5f8b

Course project added

a168937

Course project update

561da00

Course project tests update

726df11

Course project tests update2

abdbf4b

ArtemNikolaev1 reviewed Sep 20, 2021

View reviewed changes

NikolaevArtem added Course Project and removed readyForReview Sign for Artem to take a look labels Sep 20, 2021

NikolaevArtem reviewed Sep 20, 2021

View reviewed changes

src/main/java/homework_3/Cafe.java

* Immutable class is extremely well encapsulated!

*/

public final class Cafe {

Copy link

Owner

NikolaevArtem Sep 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

NikolaevArtem added the HW_3 label Sep 20, 2021

NikolaevArtem reviewed Sep 20, 2021

View reviewed changes

NikolaevArtem added the HW_4 label Sep 20, 2021

NikolaevArtem reviewed Sep 20, 2021

View reviewed changes

NikolaevArtem added HW_5 HW_6 labels Sep 20, 2021

NikolaevArtem reviewed Sep 20, 2021

View reviewed changes

NikolaevArtem approved these changes Sep 20, 2021

View reviewed changes

NikolaevArtem added the HW_7 label Sep 20, 2021

		if (!tail.equals("")) {
		throw new IllegalArgumentException();

Conversation

Sotheres commented Jul 8, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Sotheres Jul 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NikolaevArtem commented Jul 25, 2021

Uh oh!

ArtemNikolaev1 Sep 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NikolaevArtem Sep 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NikolaevArtem left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Sotheres Jul 17, 2021 •

edited

Loading

ArtemNikolaev1 Sep 20, 2021 •

edited

Loading

NikolaevArtem Sep 20, 2021 •

edited

Loading