First replaceCharacterList, then transformLabel#35
Open
blueambr wants to merge 1 commit intoNiklasMencke:mainfrom
Open
First replaceCharacterList, then transformLabel#35blueambr wants to merge 1 commit intoNiklasMencke:mainfrom
blueambr wants to merge 1 commit intoNiklasMencke:mainfrom
Conversation
When we use transformLabel together with replaceCharacterList, we don't reach the replaceCharacterList condition, because we return the result of transformLabel function. In order to use them together, I moved replaceCharacterList to the beginning. This way they can work together.
|
@hotepp Thanks for the fix! @NiklasMencke any way we can get this approved and merged? Myself and others are using this on our own projects and have been running into issue #33 and this fixes it. Thanks, Jorge |
|
I am looking to provide further improvement, after this issue has been resolved. Any news on that status of this npm package? Is it still being maintained? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we use transformLabel together with replaceCharacterList, we don't reach the replaceCharacterList condition, because we return the result of transformLabel function. In order to use them together, I moved replaceCharacterList to the beginning. This way they can work together.