forked from kwsch/NHSE
-
Notifications
You must be signed in to change notification settings - Fork 0
merge master into fork #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Nikira2023
wants to merge
81
commits into
Nikira2023:Integrate-Fork
Choose a base branch
from
kwsch:master
base: Integrate-Fork
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added fix for two parts of pattern import problems: 1. PlayerID and TownID bytes need to be added to the pattern data from the personal.dat offsets to set them as owned and editable correctly. Added these code to get and force overwrite to fix. 2. Flags exist in main.dat for if the player has edited the pattern slot and if not, the name will not be updated correctly. Added offsets for these and added code to flag them as edited on import to fix. Added a new icon that supports up to 256px and is "distinct". Added translations to MessageStrings_jp.txt.
Added code that zeroes out the 4 bytes beginning at offset `0x70` of the pattern array that seemingly causes mismatches in imported pattern ownership. Exposed this fix via extra testing with different saves and different pattern dumps.
Shifted HorizonSave into VillagerEditor in place of MainSave and adjusted accordingly to give VillagerEditor better access to save file offsets etc. Added overwrite for Villager PRO patterns to set imported ones to be made/owned by the player for consistency. (town and player ID bytes)
Update flag wipe for placed designs
Villager PRO Design owner overwrite + bug fix for placed design path compliance
Add new revision lines for r29 (2.0.7) save files.
2.0.7 Update
Language fixes for zhs & zht.
* Upgrade to .NET 8 + Nugets * Add support for tile 16x16px instead 1px * Rivers except 2B * River2B
Update lang_ko.txt
Korean translation
Korean translation
Update internal_ko.txt
Update MessageStrings_ko.txt
Adds simple copy to clipboard to help dump nice flags as text for external comparison
Adds data for supporting 3.0.0, still needs savefile structures/hash range dumped and incorporated into MainOffsets30/PersonalOffsets30. Offsets/range is currently a copy of 2.0, which is obviously not correct. Saves will fail to load as encrypted values are not at the expected offset (pls no complaints). CTRL-I from main form still opens the injector interface; RAM offset not yet documented.
Clean up the Murmur3 implementation to be more C#-like
simple to understand; no longer need to run a separate toolchain if there (n)ever is an update in the future.
The previous method was fine, not sure what the underlying issue is. The unit tests assert that the sequence is fully replaced.
# Accidental oversight of an item that previously existed but had no remake info data
Renaming button to "Give All Furniture + Clothing" to clarify that it adds all non bug/fish/art/dive items (i.e. furn + clothes).
Updates the Field Item Editor to render layers based on the entire map, and the per-patch positioning of each layer. Import/export will gracefully handle upgrade/downgrade, and viewport import/export will gracefully update tiles rather than a per-acre basis. Performance has also been slightly improved; no allocation is done anymore when updating the image.
Closes #717
Less error prone in the future; multiple optional args are ugly, and we can infer the value using available BCL method.
When jumping viewports, pixels from the previous viewport weren't being wiped
Closes #719
Make same as plaza coordinate clamp (1024), idc what the real max is, just allow a too-high value to prevent any further errors :) Closes #721
outside.bin used to display; might be wrong on some of the outside acres (north?)
Only for entire map, not acre
Now uses json to store, manually editable Closes #644
Image no longer overlaps with controls, they'll shift down
Skip interpreting the dll from environment
…target .NET framework
# Don't pull 0 from the saved/default settings
Closes #729 1. Dark mode now applied correctly (was previously lacking) 2. Fixed terrain brush action (brush active is higher priority than drag, fix tile fetch) 3. Fixed writing of Building/structure labels; apply after Terrain 4. Single terrain brush form allowed, center to Field Editor on launch Somewhat related: fix Show() load for non-ShowDialog() forms to center to parent.
Closes #733 Fixes plaza x/y control position Fixes storage page-up/down button position
Closes #736 prob shouldn't have base acres instead of sea...
Feature: Adds support for postbox.dat via Post Box Editor and accompanying components: - Add Mail class. - Add PostBox class and corresponding offset classes. - Add wrap suppression option to ItemEditor. - Add wrapping and box dictionary to ItemWrapping class. - Add new language strings associated with forms and types. Fix: Resolved overwrite for bad dumps on all imports by adding UsageCompatibilityOffset and UsageCompatibility() added to Design classes. Transparent pixel check method added to PatternEditor and LoadPattern() altered to write the correct compatibility bytes based on type and transparency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.