Skip to content

Created men and kid section#116

Open
JagjeetChauhan wants to merge 1 commit intoNiharika0104:mainfrom
JagjeetChauhan:change-client
Open

Created men and kid section#116
JagjeetChauhan wants to merge 1 commit intoNiharika0104:mainfrom
JagjeetChauhan:change-client

Conversation

@JagjeetChauhan
Copy link

I have a simple created the men and kid section and I will continue to work on it to make it more better.

@vercel
Copy link

vercel bot commented Jun 22, 2024

@JagjeetChauhan is attempting to deploy a commit to the Niharika's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Owner

@Niharika0104 Niharika0104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use raw css use tailwind.css and also don't import components unnecessarily if you are not using them.And also images are supposed to be in public folder under Images folder.If you are hardcoding kids section data,then create a seperate data.json file for it like how I created for homepagedata.json and import that jaon file in your kids page and use it.Do the same for mens section as well.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey why did you remove social media meta tags?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have I, that might had happened accidently, that was not for any purpose.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use raw css use tailwind.css

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I will use tailwind.css

import data from '../Assests/HomePageData'
import CategoryCard from './CategoryCard'
import ProductCard from './ProductCard'
import Products from './Products'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you import products component when we aren't even using it in this HomePage.js file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants