Skip to content

Copy of psrpoppy/samb8s/bagchi fixes#1

Open
kmjc wants to merge 2 commits intoNihanPol:masterfrom
kmjc:copy_of_psrpoppy/samb8s/bagchi_fixes
Open

Copy of psrpoppy/samb8s/bagchi fixes#1
kmjc wants to merge 2 commits intoNihanPol:masterfrom
kmjc:copy_of_psrpoppy/samb8s/bagchi_fixes

Conversation

@kmjc
Copy link

@kmjc kmjc commented Sep 29, 2021

copying in fixes from psrpoppy in
samb8s/PsrPopPy@9f05510

chi was being converted to radians when already in radians
cos -> sin was already fixed
changed blurring gaussian sigma
@kmjc
Copy link
Author

kmjc commented Sep 29, 2021

Hi Nihan!
I opened this partially by mistake, I forked your repo since you python3-ized it, and then was trying to merge corrections into my own fork but it auto-pointed to yours.
But the changes might be useful so I figured I'd leave the PR in case you wanted them 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant