Check socket and ssl connection exist before closing. #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the socket or the ssl connection might not be initialized when closing, we need to check its existance before doing it.
|
getting this error as well 👍 |
|
I'm getting this too. +1 |
|
Also ran into this, I'm wondering though - why does with_connection even rescue from StandardError? Even with this PR, the error message ("The path to your pem file does not exist!") will be swallowed until the retries are over. I think the pem error messages should fail immediately, retries aren't going to help a missing pem. |
Is a new option added in iOS8 that allow users to interact with custom functionality in the context of a user task.
Support the notification action: "category" in APNS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the socket or the ssl connection might not be initialized when
closing, we need to check its existance before doing it.