Skip to content

Fix errcheck violation in RSS feed handler #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NickFoden merged 4 commits into from
Mar 2, 2026
Merged

Fix errcheck violation in RSS feed handler #22

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0826df6
Initial plan
Copilot Mar 1, 2026
876023d
Fix errcheck linting error by checking w.Write return values
Copilot Mar 1, 2026
4ffb31c
Address code review feedback: combine writes and use generic error me…
Copilot Mar 1, 2026
5e267b1
Optimize slice allocation with pre-sized capacity
Copilot Mar 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions internal/handlers/blog.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,10 +161,17 @@ func (h *BlogHandler) Feed(w http.ResponseWriter, r *http.Request) {

data, err := xml.MarshalIndent(feed, "", " ")
if err != nil {
http.Error(w, err.Error(), http.StatusInternalServerError)
http.Error(w, "Internal Server Error", http.StatusInternalServerError)
return
}

w.Write([]byte(xml.Header))
w.Write(data)
// Combine header and data into a single write to avoid partial writes
output := make([]byte, 0, len(xml.Header)+len(data))
output = append(output, []byte(xml.Header)...)
output = append(output, data...)
if _, err := w.Write(output); err != nil {
// Cannot send error response after w.Write has been called
// Log the error if needed
return
}
}